rewriter: wrap callgate header in #ifndef __ASSEMBLER__ so it doesn't get interpreted as asm
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t get interpreted as asm In `meson`, `*.S` asm files are pre-processed with the C preprocessor, and thus C flags are used to compile `*.S` asm files (unlike `*.s` asm files). To fix this on the `meson` side, we'd have to manually add args to each target instead of using `add_project_arguments(args, language: 'c')`, so this way is simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
meson,*.Sasm files are pre-processed with the C preprocessor, and thus C flags are used to compile*.Sasm files (unlike*.sasm files). To fix this on themesonside, we'd have to manually add args to each target instead of usingadd_project_arguments(args, language: 'c'), so this way is simpler.