Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CubitPy to run with Cubit Coreform #44

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

isteinbrecher
Copy link
Collaborator

No description provided.

@isteinbrecher
Copy link
Collaborator Author

@m-frey can you try if this works on your Linux machine together with Cubit Coreform? Some tests will still fail, I get the following pytest result:

============================ short test summary info =============================
FAILED testing.py::test_element_types_tet - assert False
FAILED testing.py::test_extrude_mesh_function - assert 0.6917559630511103 == 0.6934429579015018 ± 6.9e-11
FAILED testing.py::test_extrude_mesh_function_average_normals_for_cylinder_and_sphere - assert 0.02668549643643842 == 0.02675360258727785 ± 2.7e-12
FAILED testing.py::test_fluid_functionality - assert False
FAILED testing.py::test_point_coupling - assert False
FAILED testing.py::test_get_id_functions - assert [2] == [1, 2]
FAILED testing.py::test_serialize_nested_lists - TypeError: 'NoneType' object is not callable
FAILED testing.py::test_display_in_cubit - assert 'open "/tmp/c...e On\ndisplay' == 'open "/tmp/c...e On\ndisplay'
FAILED testing.py::test_extrude_artery_of_aneurysm - assert 13.570135865871498 == 13.614146346307278 ± 1.4e-04
FAILED testing_tutorial.py::TestTutorial::test_tutorial - assert False
=================== 10 failed, 27 passed, 1 warning in 38.40s ====================

Can you also try if the display_in_cubit method works?

@m-frey
Copy link

m-frey commented Nov 21, 2024

../../miniforge3/envs/meshpy/lib/python3.12/subprocess.py:1955: FileNotFoundError
================================================================================================================================================== short test summary info ==================================================================================================================================================
FAILED testing.py::test_element_types_tet - FileNotFoundError: [Errno 2] No such file or directory: 'code'
FAILED testing.py::test_extrude_mesh_function - assert 0.6917559630511103 == 0.6934429579015018 ± 6.9e-11
FAILED testing.py::test_extrude_mesh_function_average_normals_for_cylinder_and_sphere - assert 0.02668549643643842 == 0.026753602587277842 ± 2.7e-12
FAILED testing.py::test_fluid_functionality - FileNotFoundError: [Errno 2] No such file or directory: 'code'
FAILED testing.py::test_point_coupling - FileNotFoundError: [Errno 2] No such file or directory: 'code'
FAILED testing.py::test_get_id_functions - assert [2] == [1, 2]
FAILED testing.py::test_serialize_nested_lists - TypeError: 'NoneType' object is not callable
FAILED testing.py::test_display_in_cubit - assert 'open "/tmp/c...e On\ndisplay' == 'open "/tmp/c...e On\ndisplay'
FAILED testing.py::test_extrude_artery_of_aneurysm - assert 13.570135865871498 == 13.613844185308892 ± 1.4e-04
FAILED testing_tutorial.py::TestTutorial::test_tutorial - FileNotFoundError: [Errno 2] No such file or directory: 'code'
============================================================================================================================================== 10 failed, 27 passed in 21.31s ===============================================================================================================================================
(meshpy) a11bmofr@mergen ~/cubitpy/tests ((HEAD detached at ivo-fork/coreform))$ 

@isteinbrecher
Copy link
Collaborator Author

Thanks for the feedback @m-frey. Let's merge this, then CubitPy is ready for Coreform Cubit, we can have a look at the failing tests under Coreform Cubit in the future.

@isteinbrecher isteinbrecher merged commit da9705e into imcs-compsim:main Nov 21, 2024
1 check passed
@isteinbrecher isteinbrecher deleted the coreform branch November 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants