Some modernizations #101
Draft
Some modernizations #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayrmt
force-pushed
the
some-modernizations
branch
from
7bc93b5 to
79116e4
Compare
They currently relect the content of do-configure.
mayrmt
force-pushed
the
some-modernizations
branch
from
79116e4 to
ebb754e
Compare
|
@RShaw026 @isteinbrecher Rady for Review! |
|
Regarding Trilinos: with the CMake preset, I can switch to our newest pre-installed Trilinos (2024_2). In One possible outcome of this PR is to remove do-configure and switch to CMake presets entirely. Depending on this decision, we can look into changes to the Trilinos configuration. |
mayrmt
commented
Apr 21, 2025
| @@ -1,14 +1,38 @@ | |||
| cmake_minimum_required(VERSION 3.14) | |||
There was a problem hiding this comment.
If we switch to CMake presets, we need to increase this to >3.25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Some modernizations of the development tool chain:
pre-commitRelated issues and pull requests
How Has This Been Tested?
I build and ran all tests locally.
Checklist
Additional Information
I also tried to switch to update the Trilinos version presets, however this turned out to be not so straightforward. I'll leave it for the future.
Open question
do-configure?Interested Parties / Possible Reviewers
@RShaw026 @isteinbrecher