Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawlbar layer actions #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

marcelmoreau
Copy link
Contributor

moved layer__actions out of the layer—calltoAction variant as we use these in all sorts of layers, not just a dedicated variant

after moving it, modified the styles so it doesn’t automatically center, and so we can account for more than one button, and have them spaced out properly, wrapping it they need to (especially on mobile) – these 2 buttons can now be seen on the homepage and on layer—calltoAction

layer__actions also needed a modifier so we can center them if we want (which I added into layer—callToAction.twig)

there was a crawler appearing on the homepage because of two issues:

i’d like to re-do the footer completely at some point but it doesn’t cause crawlbar anymore

Marcel Moreau added 2 commits January 7, 2022 18:21
* master:
  clean up linkGroups; add twig file; update site-footer
  clean up linkGroup; add twig file
  show -primary, -secondary, and -lightGray modifiers within layer variants; collate layers
  remove legacy .-pull-left; better document how to use candlepin
  5.1.3

# Conflicts:
#	resources/styles/organisms/site-footer/site-footer.twig
@khamer
Copy link
Member

khamer commented Jan 12, 2022

  • moving layer__actions, and adding -centered are both great, make sense to me
  • We can include the grid blowout fix, though I can only replicate this issue by editing the DOM via dev tools/inspector. Nope, sorry, my bad, I see it now, good catch let's include it.
  • The footer definitely needs to be fixed, but comparing this PR's version to the existing version I'm not sure your version is going the right direction. I'd be more tempted to just do a simple fix on the existing version so that flex-direction is column for siteFooter__container and .linkGroups for small breakpoints, and change to use gap instead of left-margin (like you did in your PR.) Maybe add a gap: to .siteFooter__container too to space between the logo, nav, and social links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants