Add examples for package manager and spreadsheet #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples help me to understand how to define the API. Later, they can be used for tests and for documentation.
There was a problem hiding this comment.
I left a couple of inline comments.
For the package API, I wonder if requiring a structure of dependencies to insert a package could get you into a stalemate; maybe inserting packages and then inserting dependencies iteratively would work better in a situation where you'd parse package manifests? That's a genuine question. It could also be the case that direct, first-order dependencies can always be determined and inserted in one go.
|
@DivineDominion Thank you for the code review. I made a few changes. Can you please take a look at it again? |
|
@DivineDominion Thank you for the review again. I will merge the branch because I want to implement the methods required for these examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples help me to understand how to define the API. Later, they can be used for tests and for documentation.