Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Example App for Using Flags in Ignite Apps #46

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

Ehsan-saradar
Copy link
Contributor

This pull request introduces a new example app demonstrating how to effectively utilize flags in Ignite apps.
This example serves to illustrate best practices for incorporating flags into Ignite projects.

examples/flags/go.mod Outdated Show resolved Hide resolved
@Ehsan-saradar Ehsan-saradar marked this pull request as draft January 30, 2024 16:15
@Ehsan-saradar Ehsan-saradar force-pushed the feature/add-flags-example branch from faedc31 to f47e259 Compare February 6, 2024 11:41
@Ehsan-saradar Ehsan-saradar marked this pull request as ready for review February 6, 2024 12:05
@jeronimoalbi
Copy link
Member

Looks good 👍

Apart of the comment a nit, maybe it would be good to simplify the example removing the dependency with the github.com/Code-Hex/Neo-cowsay and maybe event the commands, leaving a single command that uses a global and a command flag, so users focus on the flags.

Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Ehsan-saradar Ehsan-saradar merged commit 61c48de into main Feb 7, 2024
9 checks passed
@Ehsan-saradar Ehsan-saradar deleted the feature/add-flags-example branch February 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants