feat: debug pkg #21
feat: debug pkg #21
Conversation
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
Pantani
force-pushed
the
feat/debug-pkg
branch
from
fb3e6f8 to
1d6ce8d
Compare
# Conflicts: # explorer/go.mod # explorer/go.sum # go.work.sum # hermes/go.sum # integration/go.sum
# Conflicts: # README.md # go.work.example
# Conflicts: # explorer/go.sum # go.work # hermes/go.sum # official/marketplace/go.sum # test/debug/go.mod # test/debug/go.sum
# Conflicts: # .github/workflows/test-integration.yml # examples/health-monitor/go.sum # explorer/go.mod # explorer/go.sum # explorer/integration/gex_test.go # hermes/go.mod # hermes/go.sum # integration/explorer/gex_test.go # integration/go.sum # marketplace/cmd/info.go # marketplace/cmd/list.go # marketplace/pkg/apps/details.go # marketplace/pkg/apps/search.go # marketplace/pkg/tree/tree_test.go # test/debug/go.mod # test/debug/go.sum # test/debug/tools.go # test/integration/explorer/gex_test.go
|
@Pantani it might be a good idea to add a "Caveat" or similar section to the readme explaining that this method doesn't support debugging interactions with the CLI. If I got it correctly this method allows debugging running App commands independently of the CLI, which means that Ignite doesn't know the PID of the App, so it won't be able to attach to it and because of that debugged Apps don't be able to communicate with Ignite to for example use the Client API. At some point I tried to create a debug app to run a debugger on apps that are connected with Ignite but I had blocking issues because the plugins system and the debugger use stdout. But maybe we could implement an "intermediate" solution using the approach in this PR and supporting dynamic attach in Ignite CLI. By the way, it might be good to scaffold debug support by default. |
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
nice, added |
No description provided.