Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(appregistry): use app registry #100

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 6, 2024

Closes: #94

  • Add install command to install apps directly from the registry
  • Rename registry fields to make more sense (omit empty, simplify structure)
  • Rename marketplace to appregistry to naming consistency
  • Update marketplace app to use app registry (instead of github topics)

@julienrbrt julienrbrt marked this pull request as ready for review June 7, 2024 09:15
@julienrbrt julienrbrt requested a review from toschdev June 7, 2024 09:18
@julienrbrt
Copy link
Member Author

We quickly talked about renaming this as extensions app, or registry app, but while thinking about it, I think we should rename this to extensions if we rename apps to extensions otherwise it reads as the extensions registry app.

Additionally, while renaming registry makes sense as well, but renaming to registry could clash with the future module registry app, and naming it is extensionsregistry leads to the same problem after.
Naming it marketplace avoid those two, while still leave place to a possible future renaming.

@julienrbrt julienrbrt changed the title refactor(marketplace): use app registry refactor(appregistry): use app registry Jun 12, 2024
@julienrbrt julienrbrt merged commit e5cd28a into main Jun 13, 2024
28 of 30 checks passed
@julienrbrt julienrbrt deleted the julien/marketplace branch June 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update marketplace app to use app registry
2 participants