fixes to clearing link

ibexa · Jan 13, 2025 · 613ff3c · 613ff3c
1 parent a1f2b9b
commit 613ff3c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/bundle/Resources/public/js/CKEditor/link/link-ui.js b/src/bundle/Resources/public/js/CKEditor/link/link-ui.js
@@ -72,9 +72,24 @@ class IbexaLinkUI extends Plugin {
     }
 
     removeAttributes(writer, element) {
+        const { link: customAttributesLinkConfig } = getCustomAttributesConfig();
+        const { link: customClassesLinkConfig } = getCustomClassesConfig();
+
         writer.removeAttribute('ibexaLinkHref', element);
         writer.removeAttribute('ibexaLinkTitle', element);
         writer.removeAttribute('ibexaLinkTarget', element);
+
+        if (customClassesLinkConfig) {
+            writer.removeAttribute('ibexaLinkClasses', element);
+        }
+
+        if (customAttributesLinkConfig) {
+            const attributes = Object.keys(customAttributesLinkConfig);
+
+            attributes.forEach((attribute) => {
+                writer.removeAttribute(`ibexaLink${attribute}`, element);
+            });
+        }
     }
 
     removeLink() {
@@ -109,7 +124,7 @@ class IbexaLinkUI extends Plugin {
         };
 
         if (customClassesLinkConfig) {
-            const defaultCustomClasses = this.isNew && customClassesLinkConfig ? customClassesLinkConfig.defaultValue : '';
+            const defaultCustomClasses = this.isNew ? customClassesLinkConfig.defaultValue : '';
             const classesValue = link?.getAttribute('class') ?? defaultCustomClasses;
 
             values.ibexaLinkClasses = classesValue;

diff --git a/src/bundle/Resources/public/js/CKEditor/link/ui/link-form-view.js b/src/bundle/Resources/public/js/CKEditor/link/ui/link-form-view.js
@@ -136,7 +136,7 @@ class IbexaLinkFormView extends View {
         this.targetSwitcherView.fieldView.isOn = !!target;
         this.targetSwitcherView.fieldView.set('isEmpty', false);
 
-        if (ibexaLinkClasses) {
+        if (ibexaLinkClasses !== undefined) {
             this.setChoiceValue(this.classesView, ibexaLinkClasses);
         }