-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perso REST: ezp -> ibexa #2346
Perso REST: ezp -> ibexa #2346
Conversation
e4bc56e
to
1e37e0e
Compare
1e37e0e
to
4dae487
Compare
Hi @ciastektk , Was the endpoint removed at some point or is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@reithor About:
I see these endpoint was removed in ezsystems/ezrecommendation-client#102 (cross-merged in https://github.com/ibexa/personalization/pull/117) and there is no replacement mentioned - it's described as useless code. Could you please remove mentions of this endpoint and then we could merge this? |
|
741ad46
to
21d8d0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @reithor for the update and enhencement.
I'm not sure about the examples using curl
format instead of HTTP format. I would have fix and update the HTTP request examples. At list, the new curl
example is correct while previous HTTP syntax was wrong (wrong regarding HTTP syntax even before being outdated regarding perso REST).
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have other HTTP request examples in the doc using curl
instead of HTTP format. It is not too complicated for a developer to convert curl to another HTTP client. And it can be useful for a first test to study the answer. No change needed there.
* ezp → ibexa --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> (cherry picked from commit 6bbfb04)
* ezp → ibexa --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
PR Fixes wrong namings (REST API)
See https://github.com/ibexa/personalization/blob/main/src/bundle/Resources/config/routing_rest.yaml for correct REST routes
Section about contenttypes endpoint needs to reevaluated - the endpoint does not exist in current release!
Checklist