Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numba to speed dependencies #104

Merged
merged 3 commits into from
Mar 2, 2025
Merged

Add numba to speed dependencies #104

merged 3 commits into from
Mar 2, 2025

Conversation

jlaehne
Copy link
Member

@jlaehne jlaehne commented Feb 4, 2025

Add numba to speed dependencies to fix failing tests and align minimum requirements with those of hyperspy.

@jlaehne
Copy link
Member Author

jlaehne commented Feb 4, 2025

pre-commit.ci autofix

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (262c077) to head (5538f63).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files          77       77           
  Lines        7476     7476           
  Branches     1023     1023           
=======================================
  Hits         6641     6641           
  Misses        568      568           
  Partials      267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne
Copy link
Member Author

jlaehne commented Feb 7, 2025

The lazy EELS fitting and background fitting is returning nan values in certain tests leading to a failure. However, this appears only from python 3.10 and not for earlier python versions.

affected tests:
exspy/tests/models/test_eelsmodel.py::TestFitBackground2D::test_lazy_only_current_false
exspy/tests/models/test_linear_model.py::TestLinearEELSFitting::test_lazy_convolved_and_std_error
exspy/tests/models/test_linear_model.py::TestLinearEELSFitting::test_lazy_nonconvolved

@ericpre @CSSFrancis : Will this be fixed by hyperspy/hyperspy#3476 ?

@ericpre
Copy link
Member

ericpre commented Feb 7, 2025

@ericpre @CSSFrancis : Will this be fixed by hyperspy/hyperspy#3476 ?

Mostly, but no entirely: there is a something else going on with the fitting convolution code, I started to have a look at it, but it turns out to be not straightforward and take time. The convolution is implemented in exspy, not hyperspy and this is why this hasn't been done in hyperspy/hyperspy#3476.

Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
@ericpre ericpre merged commit e4479ae into main Mar 2, 2025
22 of 34 checks passed
@ericpre ericpre deleted the speed-dependencies branch March 2, 2025 14:35
@ericpre ericpre added this to the v0.3.2 milestone Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants