-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numba to speed dependencies #104
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 77 77
Lines 7476 7476
Branches 1023 1023
=======================================
Hits 6641 6641
Misses 568 568
Partials 267 267 ☔ View full report in Codecov by Sentry. |
The lazy EELS fitting and background fitting is returning affected tests: @ericpre @CSSFrancis : Will this be fixed by hyperspy/hyperspy#3476 ? |
Mostly, but no entirely: there is a something else going on with the fitting convolution code, I started to have a look at it, but it turns out to be not straightforward and take time. The convolution is implemented in exspy, not hyperspy and this is why this hasn't been done in hyperspy/hyperspy#3476. |
Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
Add numba to speed dependencies to fix failing tests and align minimum requirements with those of hyperspy.