Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/user badges #1463

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Feat/user badges #1463

merged 2 commits into from
Feb 18, 2025

Conversation

zamitto
Copy link
Collaborator

@zamitto zamitto commented Feb 18, 2025

image

@zamitto zamitto marked this pull request as draft February 18, 2025 00:17
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces a user badge system to display achievements in user profiles, starting with a "Theme Creator" badge.

  • Added new UserBadge type and badges array to UserProfile interface in /src/types/index.ts
  • Created new UserBadges component in /src/renderer/src/pages/profile/profile-hero/user-badges.tsx with translation support
  • Added badge translations in both English and Portuguese locales under new badge section
  • Integrated badge display in profile hero section with proper styling and flexbox layout
  • Made UserProfileContextProviderProps readonly for better type safety in context provider

7 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@thegrannychaseroperation thegrannychaseroperation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamitto zamitto marked this pull request as ready for review February 18, 2025 01:32
Copy link
Contributor

@thegrannychaseroperation thegrannychaseroperation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

No major changes found since last review. The previous review comprehensively covered the key changes and implementation details for the user badge system. The code appears stable and ready for merging.

7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@zamitto zamitto merged commit 0bf70ff into main Feb 18, 2025
4 checks passed
@zamitto zamitto deleted the feat/user-badges branch February 18, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants