-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/user badges #1463
Feat/user badges #1463
Conversation
zamitto
commented
Feb 18, 2025
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR introduces a user badge system to display achievements in user profiles, starting with a "Theme Creator" badge.
- Added new
UserBadge
type andbadges
array toUserProfile
interface in/src/types/index.ts
- Created new
UserBadges
component in/src/renderer/src/pages/profile/profile-hero/user-badges.tsx
with translation support - Added badge translations in both English and Portuguese locales under new
badge
section - Integrated badge display in profile hero section with proper styling and flexbox layout
- Made
UserProfileContextProviderProps
readonly for better type safety in context provider
7 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
No major changes found since last review. The previous review comprehensively covered the key changes and implementation details for the user badge system. The code appears stable and ready for merging.
7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile