Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-debrid support #1452

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

All-debrid support #1452

wants to merge 11 commits into from

Conversation

mircea32000
Copy link

@mircea32000 mircea32000 commented Feb 10, 2025

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read and understood the Contributor Guidelines.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

@mircea32000 mircea32000 reopened this Feb 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR introduces All-Debrid integration as a new download source option for the Hydra launcher, with significant changes to the download services architecture.

  • Added new AllDebridClient class in src/main/services/download/all-debrid.ts with comprehensive API integration
  • Added environment variables MAIN_VITE_API_URL and MAIN_VITE_AUTH_URL in .env.example for configuration
  • Implemented magnet link handling and download URL resolution in AllDebridClient with robust error handling
  • Added type definitions for All-Debrid responses and error states in download service types
  • Integrated All-Debrid alongside existing Real-Debrid and TorBox download sources

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@mircea32000 mircea32000 reopened this Feb 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR continues the All-Debrid integration with user interface and authentication components, focusing on settings and preferences management.

  • Added settings UI component settings-all-debrid.tsx with API key management and premium account validation
  • Implemented encrypted storage of All-Debrid API keys in update-user-preferences.ts
  • Added multi-URL support in python-rpc.ts for handling All-Debrid's multiple download links
  • Added proper error handling and user feedback for All-Debrid authentication in authenticate-all-debrid.ts
  • Fixed Romanian comments in all-debrid.ts that should be translated to English

15 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile

@mircea32000 mircea32000 reopened this Feb 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR continues the All-Debrid integration with security and error handling improvements:

  • Fixed potential infinite loop in src/main/services/download/all-debrid.ts by adding proper retry limits and timeout handling
  • Added encryption for All-Debrid API key storage in update-user-preferences.ts using the Crypto service
  • Improved error handling in all-debrid.ts with specific error codes for different API failure scenarios
  • Added comprehensive logging throughout the All-Debrid client implementation for better debugging
  • Fixed non-English comments in all-debrid.ts that needed translation

The changes focus on making the All-Debrid integration more robust and secure, with better error handling and logging capabilities.

1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

@mircea32000 mircea32000 reopened this Feb 10, 2025
1 similar comment
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR update continues to refine the All-Debrid integration with user management and API improvements:

  • Enhanced HydraApi class in hydra-api.ts with robust token management and authentication flow
  • Added user profile and friends management endpoints in user events directory
  • Implemented achievement comparison functionality in get-compared-unlocked-achievements.ts
  • Added comprehensive logging throughout API interactions for better debugging
  • Improved error handling in all-debrid.ts with specific error codes for API failures

The changes focus on integrating All-Debrid within the broader user management and authentication infrastructure while maintaining security and error handling best practices.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@HelFear
Copy link

HelFear commented Feb 11, 2025

I wanted AllDebrid to come to hydra launcher, thx for your work brother!

@mircea32000
Copy link
Author

mircea32000 commented Feb 11, 2025

I wanted AllDebrid to come to hydra launcher, thx for your work brother!

let's just hope i didnt accidentally break anything lol, as far as i tested now it doesnt seem like it

@HelFear
Copy link

HelFear commented Feb 11, 2025

I wanted AllDebrid to come to hydra launcher, thx for your work brother!

let's just hope i didnt accidentally break anything lol, as far as i tested now it doesnt seem like it

Well, if you weren't already doing it, I would try myself, and I can garantee you understand more about programing than me hahaha, btw, I never used much github, I will have to wait so they can accept your merge request, or I can already merge the things you have done with my project of hydra launcher? I don't know if Im making myself clear... Hoping so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants