Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage of the CXR Foundation Google Health AI model #1222

Merged
merged 20 commits into from
Feb 26, 2025

Conversation

ndebuhr
Copy link
Contributor

@ndebuhr ndebuhr commented Feb 25, 2025

This small PR incrementally improves developer experience, by doing a pip-install-from-git installation and more broadly condensing the Hugging Face Hub usage snippet.

ndebuhr and others added 16 commits November 26, 2024 00:53
…ation models (Google Health AI), to improve their Hugging Face Hub pages and ease model adoption
…mage preprocessing and embeddings computation, not post-processing/visualization
@ndebuhr
Copy link
Contributor Author

ndebuhr commented Feb 25, 2025

@Wauplin Here's that planned follow-up PR, which simplifies the CXR Foundation installation. Look okay to you?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! That's so much better! Thanks @ndebuhr :)

`!git clone https://github.com/Google-Health/cxr-foundation.git
import tensorflow as tf, sys, requests
sys.path.append('cxr-foundation/python/')
`!pip install git+https://github.com/Google-Health/cxr-foundation.git@master#subdirectory=python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`!pip install git+https://github.com/Google-Health/cxr-foundation.git@master#subdirectory=python
`# pip install git+https://github.com/Google-Health/cxr-foundation.git#subdirectory=python

I would add this line as a comment so that the whole snippet is a python code now. Also remove the @master (implicit) to make it more robust if origin branch gets updated in the future.

@Wauplin Wauplin merged commit 80cf756 into huggingface:main Feb 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants