-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify usage of the CXR Foundation Google Health AI model #1222
Conversation
Co-authored-by: vb <vaibhavs10@gmail.com>
Co-authored-by: vb <vaibhavs10@gmail.com>
…ation models (Google Health AI), to improve their Hugging Face Hub pages and ease model adoption
…gle-hai-libraries
…gle-hai-libraries
…mage preprocessing and embeddings computation, not post-processing/visualization
…tilizes CxrClient make_hugging_face_client
…gle-hai-libraries
…gle-hai-libraries
…based installation approach
…gle-hai-libraries
…ppet function, to avoid lint errors
@Wauplin Here's that planned follow-up PR, which simplifies the CXR Foundation installation. Look okay to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice! That's so much better! Thanks @ndebuhr :)
`!git clone https://github.com/Google-Health/cxr-foundation.git | ||
import tensorflow as tf, sys, requests | ||
sys.path.append('cxr-foundation/python/') | ||
`!pip install git+https://github.com/Google-Health/cxr-foundation.git@master#subdirectory=python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`!pip install git+https://github.com/Google-Health/cxr-foundation.git@master#subdirectory=python | |
`# pip install git+https://github.com/Google-Health/cxr-foundation.git#subdirectory=python |
I would add this line as a comment so that the whole snippet is a python code now. Also remove the @master
(implicit) to make it more robust if origin branch gets updated in the future.
This small PR incrementally improves developer experience, by doing a pip-install-from-git installation and more broadly condensing the Hugging Face Hub usage snippet.