Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biology tag #1214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Feb 20, 2025

@NielsRogge
Copy link
Contributor Author

Hi @merveenoyan and @Vaibhavs10 could you have a look?

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, no, in our taxonomy system this is for sure not a pipeline type

This is a domain tag, like we have in this list in the moon repo:

export const OTHER_TAGS_SUGGESTIONS = [
	"chemistry",
	"biology",
	"finance",
	"legal",
	"music",
	"art",
	"code",
	"climate",
	"medical",
	TAG_NFAA_CONTENT,
] as const;

but it's already there

@NielsRogge
Copy link
Contributor Author

Ok will revise the PR, my goal was just so that it shows up here at the "Other" category

Screenshot 2025-02-25 at 10 40 16

@julien-c
Copy link
Member

this will not show up here, as it is not a pipeline type

@julien-c
Copy link
Member

it could be displayed here maybe

Screenshot 2025-02-25 at 10 47 57

@merveenoyan
Copy link
Contributor

merveenoyan commented Feb 25, 2025

@julien-c can we have a domain-specific taxonomy listed in other tab instead (a bit big change but needed imo)? we can have "legal" "biology" "art" "finance" to start with

@NielsRogge
Copy link
Contributor Author

Any reason not to include it in the "Other" category besides graph machine learning?

I don't think we have pipelines for graph ML, robotics and reinforcement learning models either?

I would prefer to use the term "task category" (as datasets does) for these filters on the left side bar, rather than "pipeline tags". Pipeline tags is a term that originated from the Transformers library (we used to have a one-on-one mapping between these tags and actual pipelines in Transformers). Right now these are more general task filters rather than actual pipelines

@julien-c
Copy link
Member

@merveenoyan that's what i suggest in my comment above no?

@julien-c
Copy link
Member

I don't think we have pipelines for graph ML, robotics and reinforcement learning models either?

Yes, those are not perfect either, but i'm unwilling to add to those imperfect existing ones

@julien-c
Copy link
Member

BTW note that we will probably switch to this as main interface in the future =)

models-filters-next

@merveenoyan
Copy link
Contributor

@julien-c hmm yes, I thought it was a temporary thing and not a full fledged thing

I would love that

@merveenoyan
Copy link
Contributor

@NielsRogge I kinda agree with @julien-c perhaps we could move robotics to domains and then have tasks for robotics models, e.g. vision language models are heavily used so might as well have robotics domain and image-text-to-text task tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants