-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add biology tag #1214
base: main
Are you sure you want to change the base?
Add biology tag #1214
Conversation
Hi @merveenoyan and @Vaibhavs10 could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, no, in our taxonomy system this is for sure not a pipeline type
This is a domain tag, like we have in this list in the moon repo:
export const OTHER_TAGS_SUGGESTIONS = [
"chemistry",
"biology",
"finance",
"legal",
"music",
"art",
"code",
"climate",
"medical",
TAG_NFAA_CONTENT,
] as const;
but it's already there
this will not show up here, as it is not a pipeline type |
@julien-c can we have a domain-specific taxonomy listed in other tab instead (a bit big change but needed imo)? we can have "legal" "biology" "art" "finance" to start with |
Any reason not to include it in the "Other" category besides graph machine learning? I don't think we have pipelines for graph ML, robotics and reinforcement learning models either? I would prefer to use the term "task category" (as datasets does) for these filters on the left side bar, rather than "pipeline tags". Pipeline tags is a term that originated from the Transformers library (we used to have a one-on-one mapping between these tags and actual pipelines in Transformers). Right now these are more general task filters rather than actual pipelines |
@merveenoyan that's what i suggest in my comment above no? |
Yes, those are not perfect either, but i'm unwilling to add to those imperfect existing ones |
@julien-c hmm yes, I thought it was a temporary thing and not a full fledged thing I would love that |
@NielsRogge I kinda agree with @julien-c perhaps we could move robotics to domains and then have tasks for robotics models, e.g. vision language models are heavily used so might as well have robotics domain and image-text-to-text task tag |
This PR adds a tag for "biology" models. Some relevant examples include: