[draft] Support providerModelId in inference snippets #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBrandeis
approved these changes
Feb 20, 2025
SBrandeis
requested review from
gary149,
julien-c,
pcuenca and
ngxson
as code owners
SBrandeis
deleted the
support-provider-model-id-in-inference-snippets
branch
julien-c
reviewed
Feb 25, 2025
| @@ -133,7 +133,8 @@ function generateInferenceSnippet( | |||
| provider: SnippetInferenceProvider, | |||
| opts?: Record<string, unknown> | |||
| ): InferenceSnippet[] { | |||
| return GET_SNIPPET_FN[language](model, "api_token", provider, opts); | |||
| const providerModelId = provider === "hf-inference" ? model.id : `<${provider} alias for ${model.id}>`; | |||
julien-c
reviewed
Feb 25, 2025
| opts?: Record<string, unknown> | ||
| ): InferenceSnippet[] { | ||
| if (model.tags.includes("conversational")) { | ||
| // Conversational model detected, so we display a code snippet that features the Messages API | ||
| return snippetConversational(model, accessToken, provider, opts); | ||
| return snippetConversational(model, accessToken, provider, providerModelId, opts); |
There was a problem hiding this comment.
in theory given model and provider, then providerModelId is unneeded/redundant, because model contains the provider mapping.
But in practice it's probably simpler to do it explicitly like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to correctly handle model id mapping when generating inference snippets for a given provider.
For now it's a simple PR to showcase what I had in mind in https://github.com/huggingface-internal/moon-landing/pull/12626#discussion_r1961923510 (private repo). I only implemented it for chat-completion curl snippet but the rest would follow the same pattern.
Note that we should use the mapping "only" for curl, pure Python, pure JS and openai client snippets. For
huggingface.jsandhuggingface_hubones, the model id from the Hub should be used.Note: orthogonal to this PR but I realized that some URLs are also incorrect depending on the provider.