Помощь друга #12
Merged
Помощь друга #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
| @@ -234,6 +234,7 @@ <h2 class="data-error__title">Не удалось загрузить данны | |||
| </section> | |||
| </template> | |||
| <script src="vendor/pristine/pristine.min.js"></script> | |||
| <script src="vendor/nouislider/nouislider.js"></script> | |||
js/effects.js
Outdated
Comment on lines
108
to
112
| imagePreview.className = ''; | ||
| imagePreview.style = ''; | ||
| effectLevelValue.value = ''; | ||
| effectLevel.classList.add('hidden'); | ||
| }; |
There was a problem hiding this comment.
переиспользовать код, вынося его в функции
js/effects.js
Outdated
| @@ -0,0 +1,159 @@ | |||
| const EFFECTS_DATA = { | |||
js/effects.js
Outdated
| const imagePreview = document.querySelector('.img-upload__preview img'); | ||
| const effectsContainer = document.querySelector('.effects__list'); | ||
|
|
||
| const INITIAL_EFFECT = EFFECTS_DATA.none; |
There was a problem hiding this comment.
INITIAL_EFFECT просто в camelCase или сразу строку с именем присваивать
| const unit = EFFECTS_DATA[filterName].unit; | ||
| imagePreview.style.filter = ''; | ||
|
|
||
| if (filterName !== INITIAL_EFFECT) { |
There was a problem hiding this comment.
это сравнение строки с объектом
| const onEffectsContainerChange = (evt) => { | ||
| const targetElement = evt.target.value; | ||
| useDefaultEffect(); | ||
| if (targetElement !== INITIAL_EFFECT) { |
There was a problem hiding this comment.
объекты сравниваются по ссылке
| start: 100, | ||
| step: 1, | ||
| format: { | ||
| to: (value) => Number.isInteger(value) ? value.toFixed(0) : value.toFixed(1), |
There was a problem hiding this comment.
to: (value) => Number(value),
Kartaviy-arteom
approved these changes
Feb 10, 2025
Kartaviy-arteom
merged commit 8045e5e
into
htmlacademy-javascript:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 https://htmlacademy-javascript.github.io/1582959-kekstagram-2/12/