Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app frontend dependencies, React v19, fix all typing errors, integrate hotosm/ui correctly #468

Merged
merged 16 commits into from
Feb 11, 2025

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • Previous integration of hotosm/ui worked for dev frontend, but builds were failing.
  • Updated to React v19, required to support native web components.
  • Updated all other dependencies, replacing many deprecations in tanstack-query and redux/toolkit.
  • Fix to custom type declarations, including for hotosm/ui.
  • Correctly import hotosm/ui from js files.
  • See all other updates in commit messages.

Apologies for the broken build from the previous PR!
Please review and test this thoroughly @suzit-10 πŸ™

Possible issues:

  • @react-spring/web was the only dependency that doesn't officially support React 19 I think.
  • The devs are a few days / weeks away from providing official support...
  • Extra attention should be paid to testing Tutorial/index.tsx.
  • If it doesn't work as intended, is it possible to replace the lib? Else we just wait a bit for the official support...

Screenshots

Build working:

image

Review Guide

  • Build the frontend and test!

Checklist before requesting a review

  • πŸ“– Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
  • πŸ‘·β€β™€οΈ Create small PRs. In most cases, this will be possible.
  • βœ… Provide tests for your changes.
  • πŸ“ Use descriptive commit messages.
  • πŸ“— Update any related documentation and include any relevant screenshots.

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added devops Related to deployment or configuration effort:low Likely a few hours priority:low Backlog of tasks that will be addressed in time frontend labels Feb 10, 2025
@spwoodcock spwoodcock requested a review from suzit-10 February 10, 2025 15:01
@spwoodcock spwoodcock self-assigned this Feb 10, 2025
@suzit-10
Copy link
Collaborator

Upgrade react-toastify to v11.0.0 for React v19 compatibility

@suzit-10 suzit-10 merged commit 84582e7 into develop Feb 11, 2025
2 checks passed
@spwoodcock spwoodcock deleted the build/react-19 branch February 11, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to deployment or configuration effort:low Likely a few hours frontend priority:low Backlog of tasks that will be addressed in time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants