fix: translation loading #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iChip
commented
May 29, 2024
iChip
commented
- don't load locale files dynamically
- logger references updated DD site w/ updated client token
- replace console.log's w/ logger usages
- log errors from API error handlers
| import localeEn from '@angular/common/locales/en'; | ||
| import localeZh from '@angular/common/locales/zh'; | ||
|
|
||
| registerLocaleData(localeFr, 'fr'); |
There was a problem hiding this comment.
is partner supposed to pass fr and en values? can it be fr-ca etc?
There was a problem hiding this comment.
AC is currently passing en/zh/fr (not regionalized). here are the errors i'm seeing in the console with the reverted commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.