-
-
Notifications
You must be signed in to change notification settings - Fork 45
fix(releases-widget): error display, decouple database repository object from responses and batch widget queries #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(releases-widget): error display, decouple database repository object from responses and batch widget queries #2891
Conversation
…lations BREAKING CHANGE: month unit changed from `m` to `M`
…andree5/homarr into releases-widget-error-handling
…pendent of capitalisation
…andree5/homarr into releases-widget-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, maybe wait for a review from @Meierschlumpf
…andree5/homarr into releases-widget-error-handling
@Meierschlumpf please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay nvm there are some lint issues, please fix them first
Not sure how I missed that, fixed 3461c79 |
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)Dpends on: #2497
This improves a couple points:
useSuspenseQuery
was throwing ainput too big
error. Changed this to batching the repositories in chinks of 5, and callinguseSuspenseQueries
so all the calls happen in one hook. The max number of repositories that go on a query call will depend on the size of each individual field on each repository