Skip to content

fix(releases-widget): error display, decouple database repository object from responses and batch widget queries #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 138 commits into from
May 9, 2025

Conversation

Aandree5
Copy link
Contributor

@Aandree5 Aandree5 commented Apr 17, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Dpends on: #2497

This improves a couple points:

  • User can now see the errors. Error releases will always display (regardless of the "Show Only Highlighted" swicth). By expanding the release, the user will be able to see the error message. See examples below.
  • Decoupled the database object from the response object. When in board editing mode, all the data received from the provider Api was being saved into the database as part of the object. This would in some cases cause issues, if a new release did not have a description, the description from the old release would be shown. The same would happpen with the error message.
  • Batch widget queries (fixes Release Widget - Homarr crash #2952). When adding enough repositories the useSuspenseQuery was throwing a input too big error. Changed this to batching the repositories in chinks of 5, and calling useSuspenseQueries so all the calls happen in one hook. The max number of repositories that go on a query call will depend on the size of each individual field on each repository
  • fixes Release Widget - Docker Hub rollback #2954

image
image

Andre Silva and others added 30 commits February 27, 2025 14:10
@Aandree5 Aandree5 requested a review from manuel-rw April 30, 2025 11:21
manuel-rw
manuel-rw previously approved these changes May 4, 2025
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe wait for a review from @Meierschlumpf

@manuel-rw
Copy link
Member

@Meierschlumpf please re-review

Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 💖

@Meierschlumpf Meierschlumpf self-requested a review May 6, 2025 18:07
Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay nvm there are some lint issues, please fix them first

@Aandree5
Copy link
Contributor Author

Aandree5 commented May 6, 2025

Not sure how I missed that, fixed 3461c79

@Aandree5 Aandree5 requested a review from Meierschlumpf May 6, 2025 22:11
@Meierschlumpf Meierschlumpf merged commit 347c6d1 into homarr-labs:dev May 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Widget - Docker Hub rollback Release Widget - Homarr crash
3 participants