Skip to content

feat: Scaling unification and betterment PoC #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SeDemal
Copy link
Collaborator

@SeDemal SeDemal commented Feb 15, 2025

K7fCHkN.mp4

Currently only works on the Clock widget to test the waters.

@SeDemal SeDemal requested a review from a team as a code owner February 15, 2025 09:00
Copy link

deepsource-io bot commented Feb 15, 2025

Here's the code health analysis summary for commits a58aa19..0f9c31a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@SeDemal SeDemal changed the title Scaling unification and betterment PoC feat: Scaling unification and betterment PoC Feb 15, 2025
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.56% 8701 / 40355
🔵 Statements 21.56% 8701 / 40355
🔵 Functions 26.76% 341 / 1274
🔵 Branches 62.45% 993 / 1590
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/items/item-content.tsx 0% 0% 0% 0% 1-119
packages/validation/src/shared.ts 100% 100% 100% 100%
packages/widgets/src/clock/component.tsx 0% 0% 0% 0% 1-77
packages/widgets/src/modals/widget-advanced-options-modal.tsx 0% 0% 0% 0% 1-69
packages/widgets/src/modals/widget-edit-modal.tsx 0% 0% 0% 0% 1-161
Generated in workflow #5115 for commit 0f9c31a by the Vitest Coverage Report Action

@Meierschlumpf
Copy link
Member

When I understand you concept correctly, your plan is to remove any cqmin that we used, by default use the mantine sizes and scale them with this advanced options?

@SeDemal
Copy link
Collaborator Author

SeDemal commented Feb 15, 2025

When I understand you concept correctly, your plan is to remove any cqmin that we used, by default use the mantine sizes and scale them with this advanced options?

The plan is to make the cqmin the base of the mantine sizes, so anyone can use it, and the "complex" equation should make it easy to modify in CSS so users have full control.

It's also the plan to be able to toggle cqmin/rem using this template.

The clock widget shows how easy you can implement cqmin, without ever typing the word, and only using premade "xs | sm | md | lg | xl".

Then the scaling in advanced settings helps modifying the size without ever typing it in CSS even.

I truly believe that most people's complaints are about the font being too big and not being able to control how it scales, not that it does scale up.

@Meierschlumpf
Copy link
Member

I'll close this pr for now as the users seem pretty happy with the current solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants