Developed version 2.0.17 #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rement Resolves #555.
…r issues and warnings.
Use HOBBIT UI without keycloak
…o the GUI docker container. Added a small script that exchanges the two xml files in case the UI authentication flag is set to false.
…odel using PROV-O properties.
Build all components in Docker
Feature limit resources
…bControllerTest on the assumption that the Hobbit gitlab instance is available.
…to the image manager test.
…ough it wasn't necessary.
… system properties.
denkv
approved these changes
Jan 18, 2024
platform-controller/src/test/java/org/hobbit/controller/ConnectivityAssumptionUtils.java
Show resolved
Hide resolved
platform-controller/src/main/java/org/hobbit/controller/ExperimentManager.java
Outdated
Show resolved
Hide resolved
| if (cpuCount != null) { | ||
| // We need the CPU count in nano CPU seconds (i.e., we have to multiply the | ||
| // count with 10^9) | ||
| constraints.put(ContainerManager.NANO_CPU_LIMIT_CONSTRAINT, cpuCount * 1000000000L); |
There was a problem hiding this comment.
Maybe here it would be good to have a web.archive.org link to the corresponding documentation in the comment.
There was a problem hiding this comment.
I cannot find it in the documentation of the Docker API 😬
There was a problem hiding this comment.
I cannot find it in the documentation of the Docker API 😬
That's why we need a web archive link, since Docker documentation is reliably unreliable.
There was a problem hiding this comment.
I cannot even find it in the web archive 😕
There was a problem hiding this comment.
We submit it to the archive the next time we find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USE_UI_AUTHflag and made the usage of Keycloak optional (fixes Add an option to use HOBBIT without access control #555)