-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add staking page #63
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for symphonious-beignet-5743b5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
running into errors causing build to fail while building the staking page "unable to render |
Signed-off-by: jonbray.eth <jon@xeon-protocol.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contract read/write code looks good!
found one error, the rest of the review updates are UI and style changes to make the page match the design outlined in #57
page errors
going to type a value in the stake amount immediately triggers a popup that "Amount exceeds wallet balance"
- only perform this check after the user tries to click the button
UI updates
- remove the bracket stylization around text (
epoch
,eth in pool
, etc.) - UI should be three side-by-side boxes with centered headers above each box (
Stake
,Settle
,$XEON Buyback
) - reduce header sizes
- adjust the left and right page width to ensure room for all components
- sized and position the page header and description in top left corner of page
- animation can be in the background, behind the header and description
- move
epoch
,ETH in pool
,XEON buyback
,team percentages
to the top right corner of the page, outside of a box, right justified
stake
- move the staked and wallet values here, aligned top left
- value entry, stake button, switch on the right side of the stake box, all centered vertically
settle
- header above box
- smaller box than stake
- description text and button centered in box
XEON buyback
- same size box as
settle
@RTJ99 I made some minor changes and merged the current state through in #69 so that the updates would be live but there's some minor tweaks that need to be made these are not priority changes but let's address before mainnet release next week to ensure the app looks as good as possible there's more space between stake/settle than between settle/buyback), and the border size changes with the state when they should be constant size with comfortable padding inside and around text so it doesn't look crowded for example, when switching to alignmentwe should be using a grid or column to ensure the boxes are locked into alignment 20 columns should be granular enough for the components we have, broken down as:
todo
|
Add staking, Unstaking and Voting buyback
Settle hedge still waiting for hedging contract
closes #57