Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add staking page #63

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: add staking page #63

wants to merge 20 commits into from

Conversation

RTJ99
Copy link
Contributor

@RTJ99 RTJ99 commented Sep 11, 2024

Add staking, Unstaking and Voting buyback
Settle hedge still waiting for hedging contract
closes #57

@RTJ99 RTJ99 added the DRAFT For draft PRs that are awaiting additional commits before merging label Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xeon-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:32pm

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for symphonious-beignet-5743b5 ready!

Name Link
🔨 Latest commit 58978e0
🔍 Latest deploy log https://app.netlify.com/sites/symphonious-beignet-5743b5/deploys/66eb466b56fdd10008a2a810
😎 Deploy Preview https://deploy-preview-63--symphonious-beignet-5743b5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@heyJonBray heyJonBray self-requested a review September 11, 2024 22:24
@heyJonBray heyJonBray added scope: UI Threads for addressing UX changes and improving user interface type: feature request Feature requests. Something that would be nice to have labels Sep 11, 2024
@heyJonBray
Copy link
Owner

running into errors causing build to fail while building the staking page

"unable to render /stake page"

image

Signed-off-by: jonbray.eth <jon@xeon-protocol.io>
Copy link
Owner

@heyJonBray heyJonBray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contract read/write code looks good!

found one error, the rest of the review updates are UI and style changes to make the page match the design outlined in #57

page errors

going to type a value in the stake amount immediately triggers a popup that "Amount exceeds wallet balance"

  • only perform this check after the user tries to click the button

UI updates

  • remove the bracket stylization around text (epoch, eth in pool, etc.)
  • UI should be three side-by-side boxes with centered headers above each box (Stake, Settle, $XEON Buyback)
  • reduce header sizes
  • adjust the left and right page width to ensure room for all components
  • sized and position the page header and description in top left corner of page
    • animation can be in the background, behind the header and description
  • move epoch, ETH in pool, XEON buyback, team percentages to the top right corner of the page, outside of a box, right justified

stake

  • move the staked and wallet values here, aligned top left
  • value entry, stake button, switch on the right side of the stake box, all centered vertically

settle

  • header above box
  • smaller box than stake
  • description text and button centered in box

XEON buyback

  • same size box as settle

@heyJonBray heyJonBray removed the DRAFT For draft PRs that are awaiting additional commits before merging label Sep 13, 2024
@heyJonBray
Copy link
Owner

heyJonBray commented Sep 18, 2024

@RTJ99 I made some minor changes and merged the current state through in #69 so that the updates would be live but there's some minor tweaks that need to be made

these are not priority changes but let's address before mainnet release next week to ensure the app looks as good as possible

there's more space between stake/settle than between settle/buyback), and the border size changes with the state when they should be constant size with comfortable padding inside and around text so it doesn't look crowded

for example, when switching to Unstake state, the staking box is now a different size than the rest:

image

alignment

we should be using a grid or column to ensure the boxes are locked into alignment

20 columns should be granular enough for the components we have, broken down as:

  • Stake = 7
  • Settle = 4
  • Buyback = 7
  • with a space of 1 between each box
  • constant height of 3 or 4

todo

  • ensure the box sizes are roomy enough to accommodate state changes without altering their size
  • ensure the vertical height on all boxes are the same
  • ensure elements inside of the boxes have comfortable padding around them and don't look crammed
  • switch to grid/columns for better alignment
  • reduce font weight on the text inside of boxes, buttons, etc. to reduce crowded feeling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: UI Threads for addressing UX changes and improving user interface type: feature request Feature requests. Something that would be nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add staking page
2 participants