-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow basis to fetch HEBIS Data RPB-225 #105
base: main
Are you sure you want to change the base?
Conversation
I reuse the hole transfomration, sofar no adjustments were done for specifc hebis data source. e.g. almaMmsId should be renamed hebisId
This needs to be adjusted with regard to the strapi indexing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acka47 have a look at the files named conf/output/test-hebis-to-lobid-output-n.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acka47 files named conf/hebisMarc2lobid-transformation/comparisonRpbRecords/rpb-hebis-records-n.json
are for only for comparison they are records from the productive rpb.
I tested the files against the JSON schema from https://github.com/hbz/lobid-resources/blob/master/src/test/resources/schemas/resource.json Overall, this looks good but there are apparently two subjects in the test files that do not get sufficient information in the resulting JSON. (I will add additional comments as pointers.) Here is the validation output:
We might have to add a mapping there or to ignore these subjects. However, it would probably make sense to set up an automatic test that fetches the schema from the |
"label" : "Systematik der DNB (bis 2003)", | ||
"id" : "https://bartoc.org/en/node/18497" | ||
} | ||
}, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This subject
entry is to spars wrt the lobid-resources JSON schema, see #105 (comment)
"label" : "Systematik der DNB (bis 2003)", | ||
"id" : "https://bartoc.org/en/node/18497" | ||
} | ||
}, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This subject
entry also is to sparse wrt the lobid-resources JSON schema, see #105 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same situation as above.
702074f
to
f73b85b
Compare
"id" : "https://bartoc.org/en/node/18497" | ||
} | ||
}, { | ||
"notation" : "19.1d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks something like a incorrect given notation a gnd subject classification: https://d-nb.info/standards/vocab/gnd/gnd-sc#19.1dp (label is: Persons associated with geography, with local and regional geography)
Interestingly there is a map for rppd in this repo:
rpb/conf/RPB-Export_HBZ_SWN.tsv
Line 37 in 7dcaf83
19.1dp Geographie, Heimat- und Länderkunde |
Were the wrong label is give. Not sure why.
Reuse lobid transformation for Hebis Mapping
TODO: