Skip to content

Commit

Permalink
pipeline tests - Ignore url.extension for ES < 8.14 (elastic#10685)
Browse files Browse the repository at this point in the history
Extension to elastic#9623

Ignore the existence of an invalid url.extension field. Stack versions < 8.14
had a bug that populated the field with bad data. After a package uses a minimum
stack version of 8.14.0 then this addition to dynamic_fields can be removed.

This fixes errors like this which occur under v8.14.0+

+++ got
@@ -1797,7 +1797,6 @@
                 "preserve_duplicate_custom_fields"
             ],
             "url": {
-                "extension": "com/page",
                 "original": "www.example.com/page",
                 "path": "www.example.com/page"
             }

Relates: elastic/elasticsearch#105689
  • Loading branch information
kcreddy authored Aug 6, 2024
1 parent 9a0d73f commit 11aa6d4
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'

0 comments on commit 11aa6d4

Please sign in to comment.