Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended MySQL backup and restore commands #423

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

000yesnt
Copy link

A while ago, when I had to recover a backup of my Seafile 11.0 database, a few things stood out to me:

  • As someone who isn't familiar with MySQL (or database administration in general), I didn't know mysqldump didn't save users unless the mysql database was also saved. It was a little annoying to dig through the documentation for the right command, so I added a note that reminds the reader.
    • For the Docker section, I also added a note stating that creating the seafile user isn't necessary, as the Docker backup command includes mysql
  • The mysqldump commands that are shown in the documentation lack certain options that would make the resulting dump more complete. In particular, the lack of --default-character-set=utf8mb4 creates issues with Unicode file names. I included other options that I see frequently recommended online - feedback on whether any of them are needed is appreciated.
  • The repeated mysqldump commands can be simplified by using the --databases or --all-databases options.

This PR tries to address these problems.

@freeplant freeplant added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants