#feat Switch to PostgreSQL #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszagumennov
force-pushed
the
feat/postgresql_switch
branch
2 times, most recently
from
3fdff9a to
42b3a8e
Compare
deniszagumennov
force-pushed
the
feat/postgresql_switch
branch
2 times, most recently
from
b5f0547 to
96913ef
Compare
ratik
reviewed
Nov 28, 2024
| change: number; | ||
| place: number; | ||
| }>( | ||
| 'SELECT (points + points_l1 + points_l2)::int as points, change::int as change, place::int as place FROM user_points_public WHERE address = $1 LIMIT 1', |
There was a problem hiding this comment.
it may fail due to overflow (points + points_l1 + points_l2)::int here
There was a problem hiding this comment.
Good catch, changed to ::bigint
There was a problem hiding this comment.
why can't we use numeric/decimal?
There was a problem hiding this comment.
Now using numeric and changed response type to string
ratik
reviewed
Nov 28, 2024
ratik
reviewed
Nov 28, 2024
crawler/index.ts
Outdated
| ); | ||
| const insert = db.transaction((balances) => { | ||
| async (balances: UserBalance[]) => { | ||
| const callbackDbClient = await connect(false, config, logger); |
There was a problem hiding this comment.
this can lead to pool exhaustion, please make sure connection pool size is like around 20-30 or so
There was a problem hiding this comment.
Using a connection pool with 30 connections now
ratik
reviewed
Nov 28, 2024
Comment on lines
+5
to
+11
| const client = new Client({ | ||
| host: 'localhost', | ||
| port: 5432, | ||
| database: 'crawler', | ||
| user: 'admin', | ||
| password: 'password', | ||
| }); |
There was a problem hiding this comment.
Yes, I tried to support test scripts in /db directory. If we dont need them for now, I can remove them from the repo
deniszagumennov
force-pushed
the
feat/postgresql_switch
branch
from
e957b46 to
93466f9
Compare
deniszagumennov
force-pushed
the
feat/postgresql_switch
branch
from
4be0902 to
e5307da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.