Merge pull request #17 from gwu-libraries/t14-fix-tests

Fixes #14. Updates tests
gwu-libraries · Dec 2, 2019 · 0ef8583 · 0ef8583
2 parents 8771f7d + 41f5dcf
commit 0ef8583
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 26 deletions.
diff --git a/README.md b/README.md
@@ -197,7 +197,13 @@ Please cite TweetSets as:
 
         Justin Littman. (2018). TweetSets. Zenodo. https://doi.org/10.5281/zenodo.1289426
 
-### Kibana TODO
+## Development
+### Unit tests
+  Run outside the container. 
+
+  `python -m unittest`
+
+## Kibana TODO
 * Consider multiple Kibana users.
 * Consider persistence.
 * Provide a default dashboard.

diff --git a/tests/test_models.py b/tests/test_models.py
@@ -9,10 +9,10 @@
 
 class TestTweet(TestCase):
     def test_original_extended_tweet(self):
-        tweet = to_tweet(original_extended_tweet, 'test')
+        tweet = to_tweet(original_extended_tweet, 'test', 'test_index')
         self.assertEqual('577866396094242816', tweet.meta.id)
         self.assertEqual('original', tweet.tweet_type)
-        self.assertEqual(['Test tweet 1'], tweet.text)
+        self.assertEqual(('Test tweet 1',), tweet.text)
         self.assertEqual(datetime(2015, 3, 17, 16, 17, 39, tzinfo=utc), tweet.created_at)
         self.assertEqual('2875189485', tweet.user_id)
         self.assertEqual('jlittman_dev', tweet.user_screen_name)
@@ -23,55 +23,55 @@ def test_original_extended_tweet(self):
         self.assertFalse(tweet.has_geo)
 
     def test_original_compat_tweet(self):
-        tweet = to_tweet(original_compat_tweet, 'test')
-        self.assertEqual(['Test tweet 1'], tweet.text)
+        tweet = to_tweet(original_compat_tweet, 'test', 'test_index')
+        self.assertEqual(('Test tweet 1',), tweet.text)
 
     def test_tweet_with_hashtag(self):
-        tweet = to_tweet(original_tweet_with_hashtag, 'test')
-        self.assertEqual(['hashtag'], tweet.hashtags)
+        tweet = to_tweet(original_tweet_with_hashtag, 'test', 'test_index')
+        self.assertEqual(('hashtag',), tweet.hashtags)
 
     def test_tweet_with_media(self):
-        tweet = to_tweet(original_tweet_with_media, 'test')
+        tweet = to_tweet(original_tweet_with_media, 'test', 'test_index')
         self.assertTrue(tweet.has_media)
 
     def test_tweet_with_mention(self):
-        tweet = to_tweet(original_tweet_with_mention, 'test')
-        self.assertEqual(['481186914'], tweet.mention_user_ids)
-        self.assertEqual(['justin_littman'], tweet.mention_screen_names)
+        tweet = to_tweet(original_tweet_with_mention, 'test', 'test_index')
+        self.assertEqual(('481186914',), tweet.mention_user_ids)
+        self.assertEqual(('justin_littman',), tweet.mention_screen_names)
 
     def test_tweet_with_url(self):
-        tweet = to_tweet(original_tweet_with_url, 'test')
-        self.assertEqual(['http://www.gwu.edu/'], tweet.urls)
+        tweet = to_tweet(original_tweet_with_url, 'test', 'test_index')
+        self.assertEqual(('http://www.gwu.edu/',), tweet.urls)
 
     def test_reply_tweet(self):
-        tweet = to_tweet(reply_tweet, 'test')
+        tweet = to_tweet(reply_tweet, 'test', 'test_index')
         self.assertEqual('reply', tweet.tweet_type)
-        self.assertEqual(['@justin_littman This is a test of replying to a tweet.'], tweet.text)
+        self.assertEqual(('@justin_littman This is a test of replying to a tweet.',), tweet.text)
         self.assertEqual('justin_littman', tweet.in_reply_to_screen_name)
         self.assertEqual('481186914', tweet.in_reply_to_user_id)
 
     def test_retweet(self):
-        tweet = to_tweet(retweet, 'test')
+        tweet = to_tweet(retweet, 'test', 'test_index')
         self.assertEqual('retweet', tweet.tweet_type)
-        self.assertEqual(['RT @justin_littman: Ahh ... so in the context of web crawling, that\'s what a "frontier" '
-                          'means: https://t.co/6oDZe03LsV'], tweet.text)
+        self.assertEqual(('Ahh ... so in the context of web crawling, that\'s what a "frontier" '
+                          'means: https://t.co/6oDZe03LsV',), tweet.text)
         self.assertEqual('justin_littman', tweet.retweeted_quoted_screen_name)
         self.assertEqual('481186914', tweet.retweeted_quoted_user_id)
 
     def test_quote(self):
-        tweet = to_tweet(quote_tweet, 'test')
+        tweet = to_tweet(quote_tweet, 'test', 'test_index')
         self.assertEqual('quote', tweet.tweet_type)
-        self.assertEqual(['Test 10. Retweet. https://t.co/tBu6RRJoKr',
-                          'First day at Gelman Library. First tweet. http://t.co/Gz5ybAD6os'], tweet.text)
-        self.assertFalse(tweet.urls)
+        self.assertEqual(('Test 10. Retweet. https://t.co/tBu6RRJoKr',
+                          'First day at Gelman Library. First tweet. http://t.co/Gz5ybAD6os',), tweet.text)
+        self.assertTrue(tweet.urls)
         self.assertEqual('justin_littman', tweet.retweeted_quoted_screen_name)
         self.assertEqual('481186914', tweet.retweeted_quoted_user_id)
 
     def test_streaming_extended_tweet(self):
-        tweet = to_tweet(streaming_extended_tweet, 'test')
-        self.assertEqual(['@justin_littman Some of the changes went live. This is going to be an example for a blog '
-                          'post I\'m writing that will be available at: https://t.co/MfQy5wTWBc'], tweet.text)
+        tweet = to_tweet(streaming_extended_tweet, 'test', 'test_index')
+        self.assertEqual(('@justin_littman Some of the changes went live. This is going to be an example for a blog '
+                          'post I\'m writing that will be available at: https://t.co/MfQy5wTWBc',), tweet.text)
 
     def test_geotagged_tweet(self):
-        tweet = to_tweet(geotagged_tweet, 'test')
+        tweet = to_tweet(geotagged_tweet, 'test', 'test_index')
         self.assertTrue(tweet.has_geo)