add x-gu-xid header to all requests #27762
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
force-pushed
the
add-header-x-gu-xid-to-preview-requests
branch
2 times, most recently
from
5ba6ee2 to
4643d19
Compare
this is because there is no fastly id for preview requests
marjisound
force-pushed
the
add-header-x-gu-xid-to-preview-requests
branch
from
a464a90 to
b2b6586
Compare
marjisound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a new Filter (middleware) to the the common filters and is adding
x-gu-xidheader to the request if it's missing.Context: As part of this PR #27735 the value of
x-gu-xidis retrieved and added as a log fieldfastlyRequestIdto the request logs. If the header is missing, the default valuerequest-id-not-providedis used for the log field. We then realised that there are still quite a lot of logs that are ending up withrequest-id-not-providedvalue. But it seems that some of the requests e.g.previewrequests or requests coming from nextgen, don't have thex-gu-xidheader. So this filter is explicitly adding the header in order to better associate the logs.The DCR PR that is relevant to this PR: guardian/dotcom-rendering#13266