Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS Support #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tvOS Support #101

wants to merge 1 commit into from

Conversation

aaronbrethorst
Copy link

I'm not sure what your requirements are for adding a new operating system to GRMustache, but I wanted to start a conversation with you about adding tvOS support to the project. I'm using GRMustache an app for tvOS, and would love to have support officially included so I don't have to work about tracking patches. Let me know what else I need to do!

  • Add a tvOS target to the xcodeproj and rules to the makefile to build a tvOS-compatible library.
  • Enable Bitcode for iOS and tvOS (it's required on tvOS)

* Add a tvOS target to the xcodeproj and rules to the makefile to build a tvOS-compatible library.
* Enable Bitcode for iOS and tvOS (it's required on tvOS)
@groue
Copy link
Owner

groue commented Oct 7, 2015

Hello @aaronbrethorst, I'd be glad having GRMustache running on tvOS, for sure :-)

I'm currently, on my spare time, moving GRMustache to frameworks (See PR #100). If you don't mind, would you please rebuild your PR on top of the Framework branch, the branch which tracks this PR?

So the plan is to add a framework target for tvOS, with bitcode enabled, did I understand well?

For iOS, I'd rather not enabling bitcode by default. I mean, I don't want to force users to use bitcode unless it is mandatory (tvOS, watchOS).

@groue
Copy link
Owner

groue commented Oct 7, 2015

BTW, #100 has removed the Makefile entirely, and relies on CocoaPods or Carthage for the building part.

@groue
Copy link
Owner

groue commented Oct 17, 2015

@aaronbrethorst, are you still there?

Would you please try the tvOS branch? It also contains a demo app that may help you importing the GRMustache framework in your project.

@aaronbrethorst
Copy link
Author

Hi, yeah, sorry. I've been neck-deep in getting my tvOS app finished up. I should be able to get things moving in 2-3 days. Sorry for the delay :(

@groue
Copy link
Owner

groue commented Oct 18, 2015

Don't apologize, we are are all working, and this also explain the delay in my own answer to your PR :-) Just tell me if the tvOS branch works for you. Beware: GRMustache is no longer a static lib, but a framework now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants