Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): getCwd bundle failed on cloudflareD1R2Worker #126

Merged

Conversation

minhhieu76qng
Copy link
Contributor

@minhhieu76qng minhhieu76qng commented Feb 20, 2025

After version 0.10.1, @gronxb added enableHermes options in the pull request #120 that introduces a build failure.

I get the error when init the hot-updater using command yarn hot-updater init.

file:///Users/minhhieu76qng/dev/dsv/my-project/node_modules/hot-updater/dist/index.js:22416
        paths: [
               ^

ReferenceError: getCwd is not defined
    at deployWorker (file:///Users/minhhieu76qng/dev/dsv/my-project/node_modules/hot-updater/dist/index.js:22416:16)
    at initCloudflareD1R2Worker (file:///Users/minhhieu76qng/dev/dsv/my-project/node_modules/hot-updater/dist/index.js:22633:30)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Command.init_init (file:///Users/minhhieu76qng/dev/dsv/my-project/node_modules/hot-updater/dist/index.js:22889:13)

After checking the bundle, I found that the getCwd() function is not built.
image
And I change the code which is presented in my PR, the getCwd() is built successfully.
image

@minhhieu76qng
Copy link
Contributor Author

Please help me to review the PR @gronxb

Copy link
Owner

@gronxb gronxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😅 I missed it.

@gronxb gronxb changed the title fix: getCwd bundle failed on cloudflareD1R2Worker fix(cli): getCwd bundle failed on cloudflareD1R2Worker Feb 20, 2025
@gronxb gronxb merged commit 231132d into gronxb:main Feb 20, 2025
1 check passed
@gronxb
Copy link
Owner

gronxb commented Feb 20, 2025

Release 0.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants