-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.3.0 #36
Open
greluc
wants to merge
73
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the project version from 1.1.0 to 1.2.0 in build configuration and BOM files. Upgrade JUnit dependency from version 5.11.4 to 5.12.0 to include the latest improvements and fixes. Adjust related references in CycloneDX BOM JSON and XML files accordingly. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update the changelog with details about features and dependency updates in v1.2.0. Modify SECURITY.md to include the new version, update support status, and add a placeholder for the VirusTotal link. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Group and reorder FXML imports for various files to enhance clarity and maintain consistency in structure. These changes improve readability and facilitate future updates or modifications without altering the file functionality. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Introduce a "Show All" checkbox in the ScanViewController to toggle the visibility of all kill events, regardless of filters. Refactor kill-event processing and display logic to improve clarity, reuse, and user experience. Update related components and documentation to reflect these changes. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Introduce a dedicated mockitoAgent configuration to support Mockito's Java agent and configure it in the test JVM arguments. Ensure transitive dependencies are excluded for the agent, maintaining a lean dependency setup. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Downgrade JUnit from 5.12.0 to 5.11.4 to address compatibility issues. Ensure consistent behavior across the build process. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify the workflow by replacing the specific commit hash with the tagged version. Ensures easier readability and maintainability for future updates or references. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update the branch list formatting in the Gradle workflow file for consistency and readability. This aligns the push and pull_request branch array syntax with a more explicit list format. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update `serialNumber` and `timestamp` fields in both JSON and XML BOM files. Change the property `cdx:maven:package:test` value from `true` to `false`. Remove a block of copyright comments from the XML file for simplification. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Corrects "kill" to "kills" for consistency and accuracy in the changelog. Ensures clarity in the documented feature update. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Replace the placeholder link with the correct VirusTotal URL for version 1.2.0. Ensures accurate reference and improves documentation reliability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Include a GitHub license badge to provide quick visibility of the project's licensing information. This improves transparency and accessibility for users. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Expand the killer filtering logic to include "pu_", "npc_", and "kopion_". This ensures that events involving these killer types are now handled in the same way as others, improving consistency in event processing. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update the default value for the scan interval from 1 second to 60 seconds in both `SettingsHandler` and `SettingsData`. This ensures a more practical default behavior and reduces the frequency of unnecessary scans. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Upgrade Checkstyle to Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Upgrade `sckillmonitor` to version 1.2.1, `checkstyle` to 10.21.3, and `commons-beanutils` to 1.10.1 in both XML and JSON BOM files. Adjust hashes and references accordingly to ensure compatibility and consistency across the project. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Introduce `evaluatedKillEvents` to track and prevent duplicate rendering of kill events. Clear `evaluatedKillEvents` and UI elements when toggling the "Show All" checkbox to ensure consistent updates. Streamline `displayKillEvents` by eliminating redundant clearing logic. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Reduce indentation inconsistencies and adjust formatting for better clarity. No functional changes are introduced; the refactor ensures code maintainability and eases future modifications. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Replace abrupt application termination (`System.exit`) with error alerts for better user feedback. Introduce `AlertHandler` to display errors and ensure the application stops gracefully using `onStopPressed`. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Synchronize version annotations in Java files and update SECURITY.md with version 1.2.1 details. Mark 1.2.0 as unsupported and add a placeholder VirusTotal link for 1.2.1. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Extract the formatting logic from KillEvent to a new KillEventFormatter class, improving separation of concerns. This change simplifies KillEvent while ensuring more reusable and maintainable string formatting functionality. Updated ScanViewController to use the new formatter. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify the method by replacing AtomicReference usage with direct Optional mapping. Improves code readability and maintains functional equivalence. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Eliminate the unused `AtomicReference` import to clean up the code. Additionally, adjust JavaDoc formatting for improved readability and consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update the JavaDoc comments to improve clarity and consistency. Replace improperly formatted tags with proper usage of {@link} and adjust paragraph styling for better readability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
…ling. Replaces error alerts with logging statements and improves log message consistency. Removes unnecessary `AlertHandler` usage, streamlining the code for better maintainability. Enhances logs with more relevant details to aid debugging. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Introduce the `weaponClass` field to `KillEvent` and include it in the formatter, parsing logic, and UI display. Adjust the kill event pane height to improve layout consistency. Update the changelog to document the addition of the new feature. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Move kill event parsing and extraction logic from ScanViewController to the new KillEventExtractor class for improved modularity and separation of concerns. Update related methods and imports, and rename showFileChooser() to openFileChooser() for clarity. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Previously, the extraction logic used the current time for each invocation, creating potential inconsistencies. This change ensures the extraction process uses a fixed scan start time for uniformity and reliability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Update JavaDoc to provide clearer and more detailed descriptions of methods and class responsibilities in `ScanViewController`. Refactor comments for better readability and consistency, highlighting key features, initialization steps, and handling of kill events during scans. Ensure proper semantic alignment with current functionality. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
# Conflicts: # CHANGELOG.md # SECURITY.md # build.gradle.kts # docs/bom/bom.json # docs/bom/bom.xml # src/main/java/de/greluc/sc/sckm/AlertHandler.java # src/main/java/de/greluc/sc/sckm/Constants.java # src/main/java/de/greluc/sc/sckm/FileHandler.java # src/main/java/de/greluc/sc/sckm/ScKillMonitorApp.java # src/main/java/de/greluc/sc/sckm/controller/AboutViewController.java # src/main/java/de/greluc/sc/sckm/controller/MainViewController.java # src/main/java/de/greluc/sc/sckm/controller/ScanViewController.java # src/main/java/de/greluc/sc/sckm/controller/SettingsViewController.java # src/main/java/de/greluc/sc/sckm/controller/StartViewController.java # src/main/java/de/greluc/sc/sckm/data/KillEvent.java # src/main/java/de/greluc/sc/sckm/settings/SettingsData.java # src/main/java/de/greluc/sc/sckm/settings/SettingsHandler.java # src/main/java/de/greluc/sc/sckm/settings/SettingsListener.java # src/test/java/de/greluc/sc/sckm/settings/SettingsDataTest.java
Rename `isShowAll` to `isShowAllActive` and adjust corresponding method and variable names for better clarity. Update logic to include `isKillerModeActive` in kill event evaluation where applicable. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
# Conflicts: # CHANGELOG.md # build.gradle.kts # src/main/java/de/greluc/sc/sckm/AlertHandler.java # src/main/java/de/greluc/sc/sckm/Constants.java # src/main/java/de/greluc/sc/sckm/FileHandler.java # src/main/java/de/greluc/sc/sckm/ScKillMonitorApp.java # src/main/java/de/greluc/sc/sckm/controller/AboutViewController.java # src/main/java/de/greluc/sc/sckm/controller/MainViewController.java # src/main/java/de/greluc/sc/sckm/controller/ScanViewController.java # src/main/java/de/greluc/sc/sckm/controller/SettingsViewController.java # src/main/java/de/greluc/sc/sckm/controller/StartViewController.java # src/main/java/de/greluc/sc/sckm/data/KillEvent.java # src/main/java/de/greluc/sc/sckm/data/KillEventExtractor.java # src/main/java/de/greluc/sc/sckm/data/KillEventFormatter.java # src/main/java/de/greluc/sc/sckm/settings/SettingsData.java # src/main/java/de/greluc/sc/sckm/settings/SettingsHandler.java # src/main/java/de/greluc/sc/sckm/settings/SettingsListener.java # src/main/resources/de/greluc/sc/sckm/fxml/SettingsView.fxml # src/test/java/de/greluc/sc/sckm/settings/SettingsDataTest.java
Update the text label from "Killer mode" to "Killer Mode" in the SettingsView.fxml file to ensure consistency with UI text capitalization rules. This improves the user interface by maintaining a standardized and professional appearance. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Include descriptive placeholder text for all input fields to improve usability. This helps users understand the expected content for each field at a glance. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Inserts a branded image with a link to the Star Citizen website in the README. Also adds the corresponding image file to the project resources. This improves the visual appeal and provides easier access to relevant external content. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Inserts a branded image with a link to the Star Citizen website in the README. Also adds the corresponding image file to the project resources. This improves the visual appeal and provides easier access to relevant external content. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Add Game.log to the .gitignore file to prevent it from being tracked in Git. This ensures that temporary or generated log files do not clutter the version control system. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Upgrade Checkstyle to 10.21.4, JUnit to 5.12.0, Jackson to 2.18.3, and Lombok plugin to 8.12.2.1. Adjust the BOM file to reflect updated versions and metadata changes. This ensures compatibility and incorporates the latest improvements and fixes. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Revert JUnit dependencies in `build.gradle.kts` and BOM files from 5.12.0 to 5.11.4. Ensures compatibility with other dependencies and resolves potential version conflicts. Updated checksums and metadata reflect the downgraded packages. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Replace the old logo with a new image file (sckm.jpg) for the application icon. Add the missing sckm.jpg file to the project's resources to ensure proper display. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Remove unused file and rolling file appenders from `log4j2.properties` to simplify the logging setup. Adjust root logger configuration to only use the console appender and set the logging level to `error`. Create a backup of the original `log4j2.properties` for reference. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
The image file is no longer needed and is removed to clean up unused resources. This helps reduce unnecessary clutter in the repository. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Introduce labels to display kill and death counts in the UI, updating dynamically during the scanning process. Enhance kill event handling logic to track statistics, reset counters, and display data based on user settings. Refactor file writing and kill event processing for improved clarity and functionality. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Replace the GNU General Public License with the Apache License 2.0 in wrapper scripts. Update Gradle to version 8.13, add network timeout, validate distribution URL, and enhance error handling in scripts for better reliability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Rename workflow file for clarity and update triggers to include `workflow_dispatch` and `workflow_call`. Modify the build step to use `installDist` and upload build artifacts for better distribution. Ensure consistent formatting across steps for improved readability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Rename workflow file for clarity and update triggers to include `workflow_dispatch` and `workflow_call`. Modify the build step to use `installDist` and upload build artifacts for better distribution. Ensure consistent formatting across steps for improved readability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Rename workflow file for clarity and update triggers to include `workflow_dispatch` and `workflow_call`. Modify the build step to use `installDist` and upload build artifacts for better distribution. Ensure consistent formatting across steps for improved readability. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify the workflow YAML by eliminating unnecessary comments and documentation, improving readability and maintainability. The functionality remains unchanged, and the core steps for building and dependency submission are preserved. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify the workflow YAML by eliminating unnecessary comments and documentation, improving readability and maintainability. The functionality remains unchanged, and the core steps for building and dependency submission are preserved. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Ensure the main application window cannot be resized by setting maximum width and height to match the minimum dimensions. This improves the user experience by enforcing a consistent UI layout. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Simplify CI by focusing on building and packaging artifacts, splitting dependency submission into its workflow. Remove `deploy.yml` and redundant settings in `ci.conveyor.conf` to streamline processes. Update `rdns-name` in `conveyor.conf` for naming consistency. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
…onitor.png" Replace the old icon image references with "sckm.jpg" in the MainViewController. This ensures a consistent and updated application branding for both the Settings and About views. Signed-off-by: Lucas Greuloch (greluc) <lucas.greuloch@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingsView
.