[teleport-update] Improve clarity of error logs and address UX edge cases #52777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(moving to draft to look into a more comprehensive fix for the --force flag change) |
sclevine
changed the title
sclevine
changed the title
|
Ready for review |
camscale
reviewed
Mar 11, 2025
camscale
approved these changes
Mar 11, 2025
vapopov
approved these changes
Mar 12, 2025
hugoShaka
reviewed
Mar 12, 2025
hugoShaka
approved these changes
Mar 12, 2025
public-teleport-github-review-bot
bot
removed the request for review
from avatus
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
sclevine
force-pushed
the
sclevine/autoupdates-feedback
branch
from
fc35ca5 to
48065ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adds a few minor usability tweaks to teleport-update:
teleport-update statushas more clear output when Teleport is not installedteleport-update uninstallno longer requires the --force flag when run with a non-conflicting suffixchangelog: Improve clarity of error logs and address UX edge cases in teleport-update
The
teleport-updatebinary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/opt/teleport.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/11856