feat!: Upgrade to Binaryen v115 #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
reviewed
Feb 16, 2025
| @@ -7,11 +7,11 @@ | |||
| (i32.const 0) | |||
| ) | |||
| (module | |||
| (type $i32_i32_=>_i32 (func (param i32 i32) (result i32))) | |||
There was a problem hiding this comment.
Just out of curiosity do you know why these are no longer named?
There was a problem hiding this comment.
They probably just changed the way the printing works.
There was a problem hiding this comment.
IIRC they actually encourage you to use unique types for everything so it can optimize better, so they probably stopped naming the types like this so there aren't conflicts.
|
Pinned to an older version of ocamlfind and opened esy-ocaml/esy-opam-override#139. |
|
Can you make sure there's a semantic commit for the rename of multi memory so the changelog includes it as a breaking change? |
|
Yeah, I'll add it when I rebase this PR. |
phated
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full Binaryen diff available here: WebAssembly/binaryen@version_114...version_115
Most notable change is that the
multi_memoriesfeature has been renamed tomulti_memory.