-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix span status report #1784
Fix span status report #1784
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
==========================================
+ Coverage 65.36% 67.26% +1.90%
==========================================
Files 203 219 +16
Lines 20884 22607 +1723
==========================================
+ Hits 13650 15207 +1557
- Misses 6360 6631 +271
+ Partials 874 769 -105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
So what I reported in #1773 was actually the opposite. Status was always ok but errors etc was not reported correctly. |
Span status report was reported as a numeric 0, 1, 2, where it should be a string:
STATUS_CODE_OK
,STATUS_CODE_ERROR
orSTATUS_CODE_UNSET
.Also, reported status code was always unset or error, but never OK.
Fixes #1773