fix off by 1 potentially affecting optimal hyperparams

see 2013 discussion: clab#4
graehl · Jan 29, 2025 · 3ebcb88 · 3ebcb88
1 parent b3a83fe
commit 3ebcb88
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/fast_align.cc b/src/fast_align.cc
@@ -204,7 +204,7 @@ void UpdateFromPairs(const vector<string>& lines, const int lc, const int iter,
         for (unsigned i = 1; i <= src.size(); ++i) {
           const double p = probs[i] / sum;
           s2t->Increment(src[i - 1], f_j, p);
-          emp_feat_ += DiagonalAlignment::Feature(j, i, trg.size(), src.size()) * p;
+          emp_feat_ += DiagonalAlignment::Feature(j + 1, i, trg.size(), src.size()) * p;
         }
       }
       local_likelihood += log(sum);