Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have playback stop at eof instead of waterfall smear #1404

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhassell
Copy link

@mhassell mhassell commented Jan 19, 2025

I added logic to the IQ playback tool to stop playback when we hit eof to prevent the smeared waterfall.

This is my first work on GQRX so I started simple. Please let me know if there is more in the PR review process.

@argilo
Copy link
Member

argilo commented Feb 4, 2025

Thanks for the contribution.

I agree it's annoying that DSP processing doesn't stop when the end of the file is reached. One thing I wonder about though: the UI slider is free-running and not synchronized to the actual file playback. Is it possible that the slider might reach its maximum value before EOF is reached, which would cause playback to stop too early?

@argilo argilo added the feature label Feb 4, 2025
@mhassell
Copy link
Author

mhassell commented Feb 4, 2025

@argilo I did test the build with these changes and did confirm with IQ files of various lengths (6s - 5min) that playback stops at the end of the file. I also tried sliding the slider back and forth while playing back the files and it did not break anything. So I think that is good.

It looks like the failure in the pipeline was for the windows build on files I didn't change. Is that a pre-existing problem?

@argilo
Copy link
Member

argilo commented Feb 4, 2025

Yes, the problem with the Windows build was fixed on the master branch after you created your PR.

@mhassell
Copy link
Author

mhassell commented Feb 4, 2025

Okay. I tried merging master into my branch but it didn't catch anything. (shrug)

@argilo
Copy link
Member

argilo commented Feb 5, 2025

Perhaps you didn't pull the master branch before you did that?

I usually do a rebase instead of merge to keep the commit history cleaner.

@mhassell
Copy link
Author

mhassell commented Feb 5, 2025

I'm an idiot and learned the minutiae of branches this morning. Merged master a moment ago and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants