Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corretly generate goversions #88

Merged
merged 9 commits into from
Feb 13, 2024
Merged

fix: corretly generate goversions #88

merged 9 commits into from
Feb 13, 2024

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Feb 12, 2024

Closes: #87

csv header was removed in the rewritten version of golang-versions generator.
When I resolved the conflict in #77, I didn't notice that the b4737e6 was generated by the old generation code. This patch migrates the old style data to the latest.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de41912) 78.87% compared to head (babcdfc) 79.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
+ Coverage    78.87%   79.18%   +0.31%     
===========================================
  Files           15       15              
  Lines         3474     3526      +52     
===========================================
+ Hits          2740     2792      +52     
  Misses         518      518              
  Partials       216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zxilly Zxilly marked this pull request as draft February 12, 2024 11:56
@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

Seems some other error exists.

@Zxilly Zxilly marked this pull request as ready for review February 12, 2024 15:52
@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

@TcM1911 The old implementation will get into deadlock when some of the request failed and throw an error. This patch fixes it.

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

I think it might be an error on rate limiting of GitHub REST API. So I also add a check mechanism to prevent duplicate requests.

@TcM1911
Copy link
Member

TcM1911 commented Feb 12, 2024

That make sense. I poked around a bit and it looks like the issue is around generating the std packages. We are hitting the API pretty hard so maybe we should just do a git clone of the go source and walk the folder instead. What do you think of that as an approach?

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

I think it's possible. I will try to implement it with git cat-file or something.

@TcM1911
Copy link
Member

TcM1911 commented Feb 12, 2024

I can merge this for now.

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

I'd like to stick with this PR, my local branch is a bit of a mess

@TcM1911
Copy link
Member

TcM1911 commented Feb 12, 2024

Sounds fine. Let me know when it is ready to be merged.

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 12, 2024

@TcM1911 I think it's ready for review.

Copy link
Member

@TcM1911 TcM1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things to fix before merge.

@Zxilly Zxilly requested a review from TcM1911 February 13, 2024 10:36
@Zxilly Zxilly requested a review from TcM1911 February 13, 2024 17:26
@TcM1911 TcM1911 merged commit c74fc91 into goretk:develop Feb 13, 2024
3 checks passed
@TcM1911
Copy link
Member

TcM1911 commented Feb 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate of moduledata timeout
3 participants