-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: corretly generate goversions #88
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #88 +/- ##
===========================================
+ Coverage 78.87% 79.18% +0.31%
===========================================
Files 15 15
Lines 3474 3526 +52
===========================================
+ Hits 2740 2792 +52
Misses 518 518
Partials 216 216 ☔ View full report in Codecov by Sentry. |
Seems some other error exists. |
@TcM1911 The old implementation will get into deadlock when some of the request failed and throw an error. This patch fixes it. |
I think it might be an error on rate limiting of GitHub REST API. So I also add a check mechanism to prevent duplicate requests. |
This reverts commit d54afa1.
That make sense. I poked around a bit and it looks like the issue is around generating the std packages. We are hitting the API pretty hard so maybe we should just do a git clone of the go source and walk the folder instead. What do you think of that as an approach? |
I think it's possible. I will try to implement it with git cat-file or something. |
I can merge this for now. |
I'd like to stick with this PR, my local branch is a bit of a mess |
Sounds fine. Let me know when it is ready to be merged. |
@TcM1911 I think it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things to fix before merge.
Closes: #87
csv header was removed in the rewritten version of golang-versions generator.
When I resolved the conflict in #77, I didn't notice that the b4737e6 was generated by the old generation code. This patch migrates the old style data to the latest.