cl testing #92
Closed
cl testing #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
added a commit
that referenced
this pull request
Feb 25, 2024
Proactive prevention of accumulating tech debt: The main purpose of this change is to make it less likely that the boilerplate code usually hidden behind the [`PYBIND11_MODULE()`](https://github.com/pybind/pybind11/blob/8b48ff878c168b51fe5ef7b8c728815b9e1a9857/include/pybind11/detail/common.h#L463-L479) macro leaks into checked-in code when PyCLIF-generated pybind11 bindings are manually converted to pure pybind11 extension modules. This change also makes it much less likely that the auto-generated module docstring and the (currently) unconditional `pybind11_protobuf::ImportNativeProtoCasters()` call leak into checked-in code. GitHub testing: #92 TGP testing is currently not needed (PyCLIF-C-API is still the default). PiperOrigin-RevId: 609818592
|
Final state of this PR equivalent to 1ce44c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper/scratch PR for testing.