feat: add gamesource layer and node #87
Conversation
maddygoround
changed the title
maddygoround
force-pushed
the
mahendra/game-source
branch
from
98cbaf3 to
69f1595
Compare
|
This pull request has been linked to Shortcut Story #21377: Implement “game source” into studio-kit. |
maddygoround
changed the title
maddygoround
force-pushed
the
mahendra/game-source
branch
from
69f1595 to
34383a2
Compare
chore: add more logging
chore: element transformer is needed fix: add element to index file chore: add more logging chore: add more logging chore: cleanup dublicate code in rtmp source chore: cleanup code
…diokit source fix: remove package-lock file from repo
maddygoround
force-pushed
the
mahendra/game-source
branch
from
91e6c6a to
92c4203
Compare
| @@ -325,19 +327,4 @@ export interface InternalEventMap { | |||
| projectId: LiveApiModel.Project['projectId'] | |||
| nodeId: SDK.SceneNode['id'] | |||
| } | |||
| // TODO: remove this code after a while when this version of sdk (1.1.58) is adopted by all users | |||
src/core/commands.ts
Outdated
| @@ -96,17 +96,15 @@ export const updateUserProps = async (payload: { | |||
| export const createSource = async (payload: { | |||
| projectId: string | |||
| displayName?: string | |||
| address?: Partial<LiveApiModel.SourceAddress> | |||
| metadata?: any | |||
There was a problem hiding this comment.
I think we were moving around allowing users to interface with the metadata property directly, in favor of "props". That way metadata.props is always reserved for renderer properties and we leave the metadata property open for other internal state as needed.
You can see this implementation in addDestination()
Not a big deal, just might be nice to update for consistency
There was a problem hiding this comment.
Thanks for the clarity; I was missing this information. Luckily, I am creating the property in metadata.props, just trying to follow how it's managed everywhere 😄 : https://github.com/golightstream/api.stream-studio-kit/blob/mahendra/game-source/examples/studio-kit-demo/src/host/host.tsx#L516
| @@ -267,105 +258,6 @@ export const prepareInternalEvents = () => { | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
This PR introduces a game source layer to the studio-kit. Additionally, we've performed a cleanup within the studio-kit by removing unused transformers and sources.
[sc-21377]