Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Option to Update Layout Only for Resolution Change in Studio Load Function #136

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

maddygoround
Copy link
Contributor

@maddygoround maddygoround commented Jan 10, 2025

Added a new option/flag to the studio.load function to conditionally trigger layout updates.

The video rendering resolution and canvas resolution are two distinct things. For canvas resolution, we strictly support 720p and 1080p, depending on the user’s plan. However, the video rendering resolution can go as low as 480p if required.

When the user modifies the video rendering resolution and reloads the project, the initial studio.load resets the video rendering resolution to match the canvas resolution. This reset is based on the user’s plan, which determines whether the canvas resolution is set to 720p or 1080p.

https://xsolla.atlassian.net/browse/LSTREAM-805

@maddygoround maddygoround marked this pull request as ready for review January 10, 2025 15:52
Copy link
Contributor

@hudbuddy hudbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a good solution 👍

@maddygoround maddygoround merged commit db65e44 into main Jan 13, 2025
1 check passed
@maddygoround maddygoround deleted the mahendra/res-fix branch January 13, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants