Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EfficacyThreshold and MutantCoverageThreshold check logic #248

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MadaManu
Copy link

@MadaManu MadaManu commented Oct 10, 2024

Proposed changes

Threshold checks should fail if they fall short of the required value (i.e., less than the threshold). However, if the actual value matches the threshold exactly (e.g., 100 out of 100), it should not be considered a failure. The threshold has been met, so no error should be reported.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes (make all) - Addressed some linter issues reported on non changed files for this fix
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@pull-request-size pull-request-size bot added the s/M Size: Denotes a Pull Request that changes 30-99 lines label Oct 10, 2024
@MadaManu
Copy link
Author

@k3rn31 can you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s/M Size: Denotes a Pull Request that changes 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant