Ignore hidden dirs, and non .m/texinfo files #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly list the sort of "format" we can deal with instead
of just assuming all non-texinfo are plain text. This is a bit
more future proof too.
Looks like there is an Octave bug where "get_help_text ('blah.m')"
can return "Not found" instead of "Not documented", work around.
Its fine in Matlab but a single entry of a string can be multiple bytes of utf-8 in Octave.
|
I'll merge this in 24 hours or so (if not objections). I'd like to release a 0.4.1 soon... |
|
One possible concern, maybe its overly verbose? BTW, if you explicitly try to test a non m-file, you'll still get an (improved) error message: (this is intended: it would be annoying to silently ignore it!) |
| continue | ||
| elseif (strcmp(f(1), '@')) | ||
| % strip @ to prevent processing as a directory | ||
| f = f(2:end); |
There was a problem hiding this comment.
Does this have any implications for when there exist both a @foo and a foo directory?
There was a problem hiding this comment.
It might! I've not changed that behaviour with this commit though. Filed #120.
"single char" might be unicode (utf-8) on Octave.
Allow existence of both `foo` and `@foo`. Fixes #120. So both `doctest @foo` and `doctest foo` will work. Strip `@` locally in the collect_targets_class() function, where it causes problems, instead of trying to do this elsewhere. When nonrecursive, stay out of `foo` when `@foo` happens to exist. Add a `test/test_shadow/`.
|
Ok, I think this is ready, although I have not yet tested on Matlab. |
|
actually, I can test on Matlab, and there seem to be some problems with classes so I will investigate. Not merge-able yet :( |
I broke this previously, by not stripping "@" during the traversal. In the new approach, we leave the problem of stripping "@" to the "collect_targets_..." functions. So add special treatment to the top of "doctest_collect" were we classify the argument.
Also, "doctest class/method". Fixes #124.
I wanted the ctor to have 2 tests and the method to have 1 so I could tell which is was doing during debugging.
|
Ok works for me now on Matlab. Also fixed another pre-existing bug on Matlab. |
Finish a sentence I left hanging (oops) and add a link to the Octave bug about using "test" on private dirs.
|
Ok to commit this? |
Despite the comments in our code, this seems to work fine. Fixes #121
cbm755
changed the title
|
Sure! |
cbm755
added a commit
that referenced
this pull request
Dec 17, 2015
Ignore hidden dirs, and non .m/texinfo files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for various bugs. I did not add config flags: I figure we can add later if there is a use case...
Most importantly it stays out of one's
.git