Skip to content

Commit

Permalink
Bump version to 0.18.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@gma
gma committed Nov 19, 2024
1 parent 30fa433 commit 5d583e8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog

## 0.18.0 (Unreleased)
## 0.18.0 (19 November 2024)

* Update Sinatra to 4.1, to fix a vulnerability.

Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
nesta (0.17.0)
nesta (0.18.0)
RedCloth (~> 4.2)
haml (>= 3.1, < 6.0)
haml-contrib (>= 1.0)
Expand Down
2 changes: 1 addition & 1 deletion lib/nesta/version.rb
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Nesta
VERSION = '0.17.0'
VERSION = '0.18.0'
end

4 comments on commit 5d583e8

@etc
Copy link

@etc etc commented on 5d583e8 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to put these comments, but wanted to alert you to two issues that came up for me, upgrading to this version:

  • My sites now work with Tilt 2.4.0 but not 2.5.0. If I use 2.5.0 I get the error uninitialized constant Tilt::MarukuTemplate (NameError)
  • My sites now require the line set :host_authorization, { permitted_hosts: [] } to be added to app.rb in my themes. If I do not do this, I get a Host not permitted error when I try to access the site (this doesn't happen running locally; only when deployed). See here for the same error in a different context. I am sure there is a more elegant way to solve the problem, and perhaps it should be solved inside Nesta itself rather than in the themes?

Happy to raise these as issues if you think some modification of Nesta is needed; otherwise, just FYI!

@gma
Copy link
Owner Author

@gma gma commented on 5d583e8 Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etc Hi Brad. It looks like Tilt 2.5.0 has dropped support for Maruku. You can continue to use 2.4.0 though, Nesta doesn't (currently) have an opinion on which 2.x version of Tilt you use, so long as it's at least 2.1. That situation will only change if Tilt introduces breaking changes, and while I suspect it'll continue to evolve, it's been fairly slow so far. So you can pin the tilt gem to version 2.4.0 in your Gemfile if you like.

Also, see this note on the future of Maruku.

Filing an issue for the second problem would be appreciated, cheers.

@etc
Copy link

@etc etc commented on 5d583e8 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Graham,

Thanks!

  • Pinning tilt to 2.4.0 is what I have done. Is there a reason for keeping Maruku support enabled in Nesta, so that this is required? Personally I'd love to phase that out and bring Pandoc support in, which I would consider moving to from Kramdown.
  • Raising an issue for the second problem now.

@gma
Copy link
Owner Author

@gma gma commented on 5d583e8 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for keeping Maruku support enabled in Nesta, so that this is required? Personally I'd love to phase that out and bring Pandoc support in, which I would consider moving to from Kramdown.

Ah, good question. I did think that I should check whether it was required by default! I'll remove it.

Cheers for filing the issue.

On pandoc support, I wonder whether a plugin (or if it's really simple, a snippet of code in a site's app.rb) might do it. I've not looked into what'd be required, but as a lot of these rendering libraries have become unmaintained and/or been removed from Tilt, it's required a reasonable amount of updates to the main project.

I've never used pandoc though, I should probably take a look and see what I think. I see that Tilt supports it for converting Markdown — is using it through Tilt what you had in mind?

Please sign in to comment.