Feature: Template flows #2975
Merged
Feature: Template flows #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-2975--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2975 +/- ##
==========================================
+ Coverage 80.00% 80.15% +0.15%
==========================================
Files 320 320
Lines 10236 10302 +66
Branches 2183 2201 +18
==========================================
+ Hits 8189 8258 +69
+ Misses 1398 1397 -1
+ Partials 649 647 -2 ☔ View full report in Codecov by Sentry. |
2 failed tests on run #5017 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Flow > should load Flow list |
Test Replay
Screenshots
|
|
| Flow > sorting by title should work perfectly |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #2975 ↗︎
mdshamoon
requested changes
Jul 15, 2024
mdshamoon
requested changes
Jul 15, 2024
| filterFlowQuery, | ||
| filterFlowQuery, | ||
| filterFlowQuery, | ||
| getFlowCountQuery(isActiveFilter), |
There was a problem hiding this comment.
At this point can you check why there are multiple calls being made to filter and count query and see if you can reduce them. If it seems to take more time, do it in a separate PR
…re/template-flows
…ntend into feature/template-flows
on view it we will show description about the template flow thats why it takes to edit page first |
…re/template-flows
mdshamoon
reviewed
Jul 23, 2024
…re/template-flows
mdshamoon
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.