Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements in interactive messages #2948

Merged
merged 30 commits into from
Jul 8, 2024
Merged

Enhancements in interactive messages #2948

merged 30 commits into from
Jul 8, 2024

Conversation

akanshaaa19
Copy link
Member

  • UI Fixes
  • Translation of interactive messages

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-2948--glific-frontend.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 09:17 Inactive
@cypress Cypress
Copy link

cypress bot commented Jun 25, 2024 •
edited
Loading

3 flaky tests on run #4918 ↗︎

0 174 0 0 Flakiness 3

Details:

Merge b1499fe into 37168cf...
Project: Glific Commit: 14fe5196c9 ℹ️
Status: Passed Duration: 25:18 💡
Started: Jul 8, 2024 8:33 AM Ended: Jul 8, 2024 8:58 AM
Flakiness  cypress/e2e/chat/ChatCollection.spec.ts • 3 flaky tests

View Output

Test Artifacts
ChatCollection > should send the message to collection Test Replay Screenshots
ChatCollection > should send the emoji to collection Test Replay Screenshots
ChatCollection > should send attachment to collection - Image Test Replay Screenshots

Review all test suite changes for PR #2948 ↗︎

@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 11:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 05:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 06:25 Inactive
This was linked to issues Jun 26, 2024
Interactive message: Changes in the interactive msg #2923
Closed
Interactive template: add the translation buttons #2942
Closed
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 07:05 Inactive
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.09524% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (b933396) to head (2d23ea6).

Files Patch % Lines
...ractiveMessage/TranslateButton/TranslateButton.tsx 84.84% 7 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2948      +/-   ##
==========================================
+ Coverage   79.08%   79.35%   +0.26%     
==========================================
  Files         318      319       +1     
  Lines        9999    10081      +82     
  Branches     2145     2159      +14     
==========================================
+ Hits         7908     8000      +92     
+ Misses       1450     1441       -9     
+ Partials      641      640       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 08:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 08:32 Inactive
@akanshaaa19 akanshaaa19 requested review from kurund and mdshamoon June 26, 2024 11:25
@github-actions github-actions bot temporarily deployed to pull request June 28, 2024 05:39 Inactive
mdshamoon
mdshamoon requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this jam as well https://jam.dev/c/a353c970-f7fb-4019-88ee-c0c415df8b72

@mdshamoon
Copy link
Member

@akanshaaa19 please check unit test cases as well. They are failing

@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 11:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 11:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 11:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 13:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 14:04 Inactive
@akanshaaa19 akanshaaa19 requested a review from mdshamoon July 1, 2024 14:07
@github-actions github-actions bot temporarily deployed to pull request July 2, 2024 04:00 Inactive
@akanshaaa19
added test cases
fd7de79
@akanshaaa19
Merge branch 'enhancement/interactive-messages' of github.com-akansha…
6b8f5d0 
…aa19:glific/glific-frontend into enhancement/interactive-messages
@github-actions github-actions bot temporarily deployed to pull request July 2, 2024 04:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 4, 2024 04:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 4, 2024 04:41 Inactive
mdshamoon
mdshamoon approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate button is still too close to simulator. Make sure to have some gap between the button and simulator. Else looks good.

Resolve conflicts and merge.

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 08:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 10:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 10:21 Inactive
@akanshaaa19 akanshaaa19 merged commit b6c8217 into master Jul 8, 2024
11 of 13 checks passed
@akanshaaa19 akanshaaa19 deleted the enhancement/interactive-messages branch July 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshamoon mdshamoon mdshamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive template: add the translation buttons Interactive message: Changes in the interactive msg
2 participants
@akanshaaa19 @mdshamoon