-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial rewrite to better support Canon EOS R. #172
Conversation
Refactor existing Canon EOS support into Canon EOS M6. Reimplement Canon EOS R support.
@hijae There was actually much less code/rewrite than I thought. There are a few areas I'm curious:
Overall, the actual implementation in |
Tested with R6m2. The camera display in the connection waiting list, and after selecting it, an error message display on the camera: Connection target not found. |
Thank you for trying. |
Also, feel free to debug if you have the time, I'd be happy to take any changes. |
esp-web-tools-logs.txt |
Thank you! |
Add the 0x03 prefix to the CanonEOSR connection handshake.
I noticed we were missing the
Except EOSR does not require/have steps 0x01 or 0x02. |
working great with R6mark2. |
I'm testing the RP and pairing well, but the focus and shutter don't work. |
Hmmm, this is concerning. All available information suggests R6 and RP should work the same way. |
I reset the RP and m5stick and tried again, but it still doesn't work. |
Hmm, can you check if the remote control mode is disabled? |
I just checked. This is a setting for using the remote control in video mode, and focus works. The focus worked in video mode. So i tested it in photo mode with stayed connected. but not working. |
OK, this very strange. I'm not sure there is any more I can offer, so I will leave this in your capable hands. |
If you haven't already, perhaps it is worth trying Canon's official app just to prove the RP is OK. |
I just connected it to my phone to check it. |
I figured it out! There was a separate remote control for drive mode. |
Excellent! I will review the PR again tomorrow and then merge. |
@hijae I also invite you to approve/review this PR if you wish. |
Refactor existing Canon EOS support into Canon EOS M6.
Reimplement Canon EOS R support.