Feat/enhance default color palettes #1016
Conversation
MAudelGisaia
commented
Nov 29, 2024
MAudelGisaia
commented
- close Enhance default color palettes for map layers #1015
MAudelGisaia
requested review from
sebbousquet,
mbarbet,
MohamedHamouGisaia and
QuCMGisaia
There was a problem hiding this comment.
I think @sebbousquet has some changes coming soon on the shared module, so we might need to wait a bit before merging this!
| @@ -35,9 +35,9 @@ h1 { | |||
|
|
|||
| .palette-selector { | |||
| @extend %palette; | |||
| height: 50px!important; | |||
There was a problem hiding this comment.
missing space before !important
| }) | ||
| export class PaletteGradientPipe implements PipeTransform { | ||
|
|
||
| public transform(selectedPalette: ProportionedValues[], min: number, max: number): unknown { |
There was a problem hiding this comment.
the return type is string
|
| @@ -1,10 +1,10 @@ | |||
| <div *ngIf="!this.selectedPalette"> | |||
| <h1 mat-dialog-title>{{ 'Select a template palette' | translate}}</h1> | |||
There was a problem hiding this comment.
I suggest to rename the title to : Select a colour palette
Change the french translation to : "Sélectionner une palette de couleurs."
| @@ -1,10 +1,10 @@ | |||
| <div *ngIf="!this.selectedPalette"> | |||
| <h1 mat-dialog-title>{{ 'Select a template palette' | translate}}</h1> | |||
There was a problem hiding this comment.
Could you please add a 5px ($sm-spacing) bottom padding to the title ?
…e height of each line. represent the palettes linearily instead of discretized buckets. new palette
MAudelGisaia
force-pushed
the
feat/enhance-default-color-palettes
branch
from
0b177d5 to
dd3a983
Compare
…e height of each line. represent the palettes linearily instead of discretized buckets. new palette
MAudelGisaia
force-pushed
the
feat/enhance-default-color-palettes
branch
from
ea0030d to
6d7ec71
Compare
MAudelGisaia
force-pushed
the
feat/enhance-default-color-palettes
branch
from
6d7ec71 to
2a0af2d
Compare
|
