Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations: add German translation #6601

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rpfaeffle
Copy link

@rpfaeffle rpfaeffle commented Mar 6, 2025

This PR adds a translation for German de_DE.

Some comments on the decisions I made (open to discuss them):

  • I choosed to use du instead of Sie as this seems appropriate
    to me.
  • I added Window (Fenster in German) to all split commands
    as it appears more naturally to me.

@mitchellh
Copy link
Contributor

I think we should block any translations without an associated maintainer. Thoughts @pluiedev? The expectation would be that they'd be part of a team that CODEOWNERS this file along with the template file so they're notified of any changes as well.

If so, would you volunteer @rpfaeffle?

@rpfaeffle
Copy link
Author

I would be happy to volunteer (at least for de_DE).

@jcollie
Copy link
Member

jcollie commented Mar 6, 2025

I think we should block any translations without an associated maintainer.

There really should be multiple maintainers so that more than one person reviews any translations before they are committed.

@pluiedev
Copy link
Member

pluiedev commented Mar 6, 2025

I agree that for a major language like German the maintainer count should be at least N = 2. For minor languages N = 1 could be fine, but we'll see.

It should be noted that new language submissions, IMO, should imply that the submitter agrees to be responsible for its maintainership for the long term. If someone doesn't want to take up that responsibility then they shouldn't contribute: no translations > crappy, outdated, unmaintained translations. I should probably add that to the translator's guide.

@mitchellh
Copy link
Contributor

There really should be multiple maintainers so that more than one person reviews any translations before they are committed.

I agree but in the interest of bootstrapping, I'd also be comfortable for major languages that are relatively easily verifiable to fallback to verifying with something like Google Translate or even an LLM. I know they're not perfectly accurate (and sometime wildly so) but as a baseline "well, it's not a racial slur" check it should work well enough.

I agree I'd prefer N >= 2 though.

Comment on lines +71 to +87
msgid "Split Up"
msgstr "Fenster nach oben teilen"

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:43
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:55
msgid "Split Down"
msgstr "Fenster nach unten teilen"

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:48
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:60
msgid "Split Left"
msgstr "Fenter nach links teilen"

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:53
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:65
msgid "Split Right"
msgstr "Fenster nach rechts teilen"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned as to how long this gets. Maybe we should split this string on the English side (so no action required from you for now) so that the two uses of Split gets separated between the context menu and the titlebar menu.

Since the titlebar menu doesn't have groups like the context menu it's fine to spell this out in full, but in the context menu it would look like "Fenster teilen > Fenster nach rechts teilen" which is quite long and redundant. Best would be "Fenster teilen > Nach rechts" I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same. For the context menu it would definitely be too long in my opinion as well. I agree with you that "Fenster teilen > Nach rechts" would be the best option .

Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please also commit the addition to src/build/GhosttyI18n.zig that makes the build system aware of the new locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants