Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for discord.js v13 #68

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

Androz2091
Copy link
Contributor

@Androz2091 Androz2091 commented Jun 18, 2021

If you are using this library and wants to switch to Discord.js, you can use this branch (npm install Androz2091/discord-paginationembed#support-djs-v13). Here is a sum up of the things you could have to change.

Breaking Changes

  • attachFiles method has been removed (as it is not included in discord.js anymore).
  • Array of strings for text is no longer supported (because the resolveString() util function of discord.js has been removed).
  • spliceFields method might be broken for discord.js v12 (not tested) but perfectly working for v13

@sawa-ko
Copy link
Contributor

sawa-ko commented Jun 22, 2021

You forgot to compile the project in the bin folder. Use the npm run test or yarn test command.

@gazmull gazmull added the breaking change This may contain significant interface modifications label Jul 16, 2021
gazmull added 4 commits July 16, 2021 23:25
Signed-off-by: gazmull <vescalaw@gmail.com>
Signed-off-by: gazmull <vescalaw@gmail.com>
Signed-off-by: gazmull <vescalaw@gmail.com>
Signed-off-by: gazmull <vescalaw@gmail.com>
@gazmull gazmull merged commit 38488a6 into gazmull:master Jul 16, 2021
@gazmull
Copy link
Owner

gazmull commented Jul 16, 2021

Will merge this for now despite the partial support (e.g. there are still breaking change issues, such as #69, but further fixes will be pushed later)

Thanks for your contribution! 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This may contain significant interface modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants